Skip to content

Fix dragleave handling to correctly remove active class across browsers #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DVSLabs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix dragleave handling to correctly remove active class across browsers #4061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions assets/js/phoenix_live_view/live_socket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,24 +683,20 @@ export default class LiveSocket {
}
});
this.on("dragleave", (e) => {
const dropzone = closestPhxBinding(
e.target,
this.binding(PHX_DROP_TARGET),
);
const closestDropZone = (el) =>
el instanceof HTMLElement
? closestPhxBinding(el, this.binding(PHX_DROP_TARGET))
: null;

if (!dropzone || !(dropzone instanceof HTMLElement)) {
const dropzone = closestDropZone(e.target) || closestDropZone(e.currentTarget);
if (!dropzone) {
return;
}

// Avoid add/remove jitter in the case that we drag into a new child and that child would
// resolve their closest drop target to the current dropzone element
const rect = dropzone.getBoundingClientRect();
if (
e.clientX <= rect.left ||
e.clientX >= rect.right ||
e.clientY <= rect.top ||
e.clientY >= rect.bottom
) {
const relatedDropzone = closestDropZone(e.relatedTarget);
if (!relatedDropzone) {
this.js().removeClass(dropzone, PHX_DROP_TARGET_ACTIVE_CLASS);
}
});
Expand Down