Skip to content

scoper behaviour for colocated css#4149

Merged
SteffenDE merged 8 commits intosd-colocatedfrom
sd-colocated-scoper
Mar 18, 2026
Merged

scoper behaviour for colocated css#4149
SteffenDE merged 8 commits intosd-colocatedfrom
sd-colocated-scoper

Conversation

@SteffenDE
Copy link
Copy Markdown
Collaborator

@SteffenDE SteffenDE commented Feb 19, 2026

See #4138.

Example scoped setup using PostCSS: SteffenDE/phx_colocated_postcss_example@e2cef37

Copy link
Copy Markdown
Contributor

@green-david green-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteffenDE Overall, this looks really great. Very much appreciate all your work here. I left a few general thoughts/comments/questions for you to ponder 👍

Comment thread config/e2e.exs Outdated
Comment thread lib/phoenix_live_view/colocated_css/scoper.ex Outdated
Comment thread lib/phoenix_live_view/colocated_css.ex Outdated
@green-david
Copy link
Copy Markdown
Contributor

@SteffenDE apologies for the ping, just checking in to see if there is anything I could help with to further the work on ColocatedCSS 👍

@SteffenDE
Copy link
Copy Markdown
Collaborator Author

I need to to talk this through with José still - just didn't have the time to do that yet. If you want, you can try using this branch in a real app and see if you encounter any issues :)

@SteffenDE SteffenDE requested a review from josevalim March 17, 2026 12:00
@SteffenDE SteffenDE force-pushed the sd-colocated-scoper branch from cc1b418 to 29d1fd3 Compare March 18, 2026 12:46
@SteffenDE SteffenDE force-pushed the sd-colocated-scoper branch from c658cd2 to 43409b7 Compare March 18, 2026 12:49
@SteffenDE SteffenDE marked this pull request as ready for review March 18, 2026 13:48
@SteffenDE SteffenDE merged commit 5134202 into sd-colocated Mar 18, 2026
7 of 8 checks passed
@SteffenDE SteffenDE deleted the sd-colocated-scoper branch March 18, 2026 13:48
SteffenDE added a commit that referenced this pull request Mar 18, 2026
* scoper behaviour for colocated css

* don't provide any default implemenation

* skip firefox in e2e test for now

* update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants