Skip to content

Optimize template rendering in Diff engine #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
preciz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize template rendering in Diff engine #4243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions lib/phoenix_live_view/diff.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ defmodule Phoenix.LiveView.Diff do
end

defp to_iodata_parts(parts, static, components, template, mapper) do
static = template_static(static, template)
one_to_iodata(static, parts, 0, [], components, template, mapper)
[head | tail] = template_static(static, template)
one_to_iodata(tail, parts, 0, [head], components, template, mapper)
end

defp keyed_to_iodata(index, keyed, static, components, template, mapper, acc)
Expand All @@ -97,13 +97,18 @@ defmodule Phoenix.LiveView.Diff do
{acc, components}
end

defp one_to_iodata([last], _parts, _counter, acc, components, _template, _mapper) do
{Enum.reverse([last | acc]), components}
defp one_to_iodata([], _parts, _counter, acc, components, _template, _mapper) do
{acc, components}
end

defp one_to_iodata([head | tail], parts, counter, acc, components, template, mapper) do
{iodata, components} = to_iodata(Map.fetch!(parts, counter), components, template, mapper)
one_to_iodata(tail, parts, counter + 1, [iodata, head | acc], components, template, mapper)
{iodata, components} =
case Map.fetch!(parts, counter) do
binary when is_binary(binary) -> {binary, components}
other -> to_iodata(other, components, template, mapper)
end

one_to_iodata(tail, parts, counter + 1, [acc, iodata | head], components, template, mapper)
end

defp template_static(static, template) when is_integer(static), do: Map.fetch!(template, static)
Expand Down
Loading