Aura hotfix 3

.github/workflows/CI.yml

@@ -0,0 +1,48 @@
+name: CI
+
+on:
+  push:
+  pull_request:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 0 1 * *' # Monthly
+
+jobs:
+  linux:
+    name: Linux-x86
+    runs-on: ubuntu-latest
+    env:
+      CONFIGURATION: release
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Update system
+        run: sudo apt update
+      - name: Install G++ (multilib)
+        run: sudo apt install -y g++-multilib
+      - name: Build
+        run: cd linux && CFG=release make
+      - name: Deploy
+        uses: actions/upload-artifact@v3
+        with:
+          name: Linux-x86
+          path: |
+            linux/release/ag.so
+            linux/release/ag.so.dbg
+  win32:
+    name: Win32
+    runs-on: windows-2019
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Add MSBuild to PATH
+        uses: microsoft/setup-msbuild@v1.0.3
+      - name: Build
+        run: MSBuild.exe projects/vs2019/projects.sln /p:Configuration=Release /p:Platform=Win32
+      - name: Deploy
+        uses: actions/upload-artifact@v3
+        with:
+          name: Win32
+          path: |
+            projects/vs2019/Release/agdll/ag.dll
+            projects/vs2019/Release/agdll/ag.pdb

SINGLEPLAYER.md

@@ -7,7 +7,9 @@ which is automatically executed right before the first map loads, thus you don't
 Singleplayer in AG has some quirks. It uses most of the multiplayer features, like vertical gauss boosting, constant 10hp falldamage...
 and some more stuff not related to multiplayer, like dead corpses being non-solid, fixes for some common crashes... you can find the changes below.
 
-If you want to run the AG% speedrunning category, there's this [AG speedrunning package](https://drive.google.com/open?id=1hSErqgUqDmbJCYJZLAHsrfC6NziW1494) that includes some fixes to the HL1 campaign maps to make them more compatible with AG and have nicer speedruns. You need AG installed, and then replace the files in your installation with the ones from the package, but make sure you backup your files just in case. You'll also need to inject the BunnymodXT included in the speedrunning package (backup your current one or put this somewhere else), which is not
+_TO DO: Update the AG speedrunning package_
+
+If you want to run the AG% speedrunning category, there's this [(OUTDATED) AG speedrunning package](https://drive.google.com/open?id=1hSErqgUqDmbJCYJZLAHsrfC6NziW1494) that includes some fixes to the HL1 campaign maps to make them more compatible with AG and have nicer speedruns. You need AG installed, and then replace the files in your installation with the ones from the package, but make sure you backup your files just in case. You'll also need to inject the BunnymodXT included in the speedrunning package (backup your current one or put this somewhere else), which is not
 merged yet with the [official BunnymodXT](https://github.com/YaLTeR/BunnymodXT), but it will be in the future after more testing and some fixes that are pending (e.g.: `bxt_autopause` not working on AG apparently).
 You inject it the same way we do for HL1 speedrunning. There's a `speedrun.cfg` in there for the required cvars to run AG%, an `example.cfg` to check some useful cvars and aliases, and some demos to learn the first chapter of the game, that you can replay with `startdemos start_1 start_2 start_3 start_4 start_5 start_6`.
 
@@ -61,6 +63,8 @@ These are the changes to singleplayer in AG 6.7 when compared to HL Steam, and s
 - HEV chargers now give at maximum 30 AP.
 - Now you start with crowbar and glock in the campaign or map.
 - Now scientists and barneys have +50 and +30 hp respectively, to be balanced with the increased weapon damage.
+- Fixed getting stuck on walls or other brushes after a changelevel (e.g.: ST pipe, after the pipe2pipe strat).
+- Fixed NPCs not being able to open doors on saveload.
 
 ## Known issues
 Some of these are specific to the HL campaign.

dlls/agarena.cpp

@@ -90,7 +90,7 @@ void AgArena::Think()
             if (GetPlayer1() && GetPlayer2())
             {
                 m_Status = Countdown;
-                m_fMatchStart = gpGlobals->time + 5.0;
+                m_fMatchStart = gpGlobals->time + GetCountdownTimeOrDefault(5.0f);
                 m_fNextCountdown = gpGlobals->time + 2.0;
             }
 

dlls/agclient.cpp

@@ -11,6 +11,8 @@
 
 #include "aggamerules.h"
 #include "agclient.h"
+#include "cvar.h"
+#include "speedrunstats.h"
 
 #include "voice_gamemgr.h"
 extern CVoiceGameMgr g_VoiceGameMgr;
@@ -31,6 +33,9 @@ extern int gmsgPlaySound;
 extern int gmsgTeamInfo;
 extern int g_teamplay;
 
+extern bool g_bPostponeChangelevel;
+extern CChangeLevel* g_pLastChangelevel;
+
 AgClient::AgClient()
 {
 
@@ -106,6 +111,7 @@ bool AgClient::HandleCommand(CBasePlayer* pPlayer)
             // player is dropping an item.
             pPlayer->DropPlayerItem((char*)CMD_ARGV(1));
         }
+        return true;
     }
     else if (FStrEq(CMD_ARGV(0), "spectate"))
     {
@@ -281,8 +287,84 @@ bool AgClient::HandleCommand(CBasePlayer* pPlayer)
     else if (FStrEq(CMD_ARGV(0), "settings"))
     {
         pPlayer->SetDisplayGamemode(0);
+
+        const auto changedCVars = CVar::GetChangesOverGamemode();
+        if (changedCVars.size() > 0)
+        {
+            AgString msg;
+
+            msg.append("These cvars have been changed:\n");
+            for (const auto changedCVar : changedCVars)
+            {
+                msg.append(UTIL_VarArgs("- %s [%s -> %s]\n",
+                    changedCVar.name.c_str(), changedCVar.defaultValue.c_str(), changedCVar.changedValue.c_str()));
+            }
+            AgConsole(msg, pPlayer);
+        }
+        else
+            AgConsole("No gamemode-related cvar changed", pPlayer);
+
+        return true;
+    }
+    else if (FStrEq(CMD_ARGV(0), "gamemodevars"))
+    {
+        if ((pPlayer->m_flLastGamemodeVarsRequest + GAMEMODE_VARS_REQUEST_COOLDOWN) > AgTime())
+            return true;
+
+        pPlayer->m_flLastGamemodeVarsRequest = AgTime();
+
+        AgString msg;
+        const auto cvars = CVar::GetGamemodeCVars();
+
+        msg.append(UTIL_VarArgs("---- Showing %d gamemode config cvars ----\n", cvars.size()));
+        for (const auto entry : cvars)
+        {
+            msg.append(UTIL_VarArgs("-> %s: %s\n", entry.first.c_str(), entry.second.c_str()));
+        }
+        AgConsole(msg, pPlayer);
+
         return true;
     }
+    else if (FStrEq(CMD_ARGV(0), "stats_run"))
+    {
+        if (singleplayer.value > 0.0f && g_bLangame)
+        {
+            SpeedrunStats::PrintRun();
+            return true;
+        }
+        return false;
+    }
+    else if (FStrEq(CMD_ARGV(0), "stats_session"))
+    {
+        if (singleplayer.value > 0.0f && g_bLangame)
+        {
+            SpeedrunStats::PrintSession();
+            return true;
+        }
+        return false;
+    }
+    else if (FStrEq(CMD_ARGV(0), "delay_changelevel"))
+    {
+        if (singleplayer.value > 0.0f && g_bLangame)
+        {
+            if (g_bPostponeChangelevel && g_pLastChangelevel)
+                g_pLastChangelevel->DoChangeLevel();
+
+            g_bPostponeChangelevel = !g_bPostponeChangelevel;
+
+            const auto msg = UTIL_VarArgs("Changelevel delay: %s\n", g_bPostponeChangelevel ? "ON" : "OFF");
+            if (ag_say_on_changelevel_delay.value != 0.0f)
+                UTIL_ServerMessage(msg);
+            else
+            {
+                // If this ever goes to multiplayer, change this AgConsole to UTIL_ClientPrintAll I guess
+                AgConsole(msg, pPlayer);
+            }
+
+            return true;
+        }
+        return false;
+    }
 #ifndef AG_NO_CLIENT_DLL
     else if (FStrEq(CMD_ARGV(0), "dropitems") && CTF == AgGametype())
     {
@@ -370,11 +452,13 @@ bool AgClient::HandleCommand(CBasePlayer* pPlayer)
         pPlayer->ShowVGUI(MENU_TEAM);
         return true;
     }
+    /*
     else if (FStrEq(CMD_ARGV(0), "agosinfo"))
     {
         AgConsole(AgOSVersion(), pPlayer);
         return true;
     }
+    */
 #ifndef AG_NO_CLIENT_DLL
     else if (FStrEq(CMD_ARGV(0), "maplist"))
     {
@@ -390,24 +474,6 @@ bool AgClient::HandleCommand(CBasePlayer* pPlayer)
     }
 #endif
 
-    /*
-    else if (FStrEq(CMD_ARGV(0), "botme"))
-    {
-          edict_t* pEntity = g_engfuncs.pfnCreateFakeClient( "botme" );
-          entvars_t *pev = &pEntity->v;
-          CBasePlayer* pBot = GetClassPtr((CBasePlayer*)pev); //Link bot object to the edict
-
-        pBot->Init();
-        pev->flags |= FL_FAKECLIENT; // bot is fakeclient
-          pBot->Spawn();
-          pev->flags |= FL_FAKECLIENT; // bot is fakeclient
-        pBot = (CBasePlayer *)CBasePlayer::Instance(pEntity);
-        g_pGameRules->PlayerThink( pBot);
-      g_engfuncs.pfnSetClientKeyValue( pPlayer->entindex(),
-          g_engfuncs.pfnGetInfoKeyBuffer(pEntity), "model", "xxx");
-    }
-    */
-
     return false;
 }
 
@@ -664,6 +730,11 @@ void AgClient::Say(CBasePlayer* pPlayer, say_type Type)
                 if (0 == ag_spectalk.value && !pPlayer->IsAdmin() && All == Type && 0 < ag_match_running.value && pPlayer != pPlayerLoop)
                     continue;
 
+                // sv_ag_match_mute 2, i'm a spec and match players won't see my message
+                if (ag_match_running.value != 0.0f && ag_match_mute.value == 2.0f
+                    && !pPlayer->IsAdmin() && !pPlayerLoop->IsSpectator() && pPlayer != pPlayerLoop)
+                    continue;
+
 #ifndef AG_NO_CLIENT_DLL
                 if (bSendLocation)
                 {
@@ -721,6 +792,12 @@ void AgClient::Say(CBasePlayer* pPlayer, say_type Type)
                 if ((Team == Type || Close == Type) && pPlayerLoop->IsSpectator())
                     continue;
 
+                // sv_ag_match_mute 2, i'm a match player and my opponents won't see my messages,
+                // but my teammates and specs will see them
+                if (ag_match_running.value != 0.0f && ag_match_mute.value == 2.0f
+                    && !pPlayer->IsTeammate(pPlayerLoop) && !pPlayerLoop->IsSpectator())
+                    continue;
+
 #ifndef AG_NO_CLIENT_DLL
                 if (bSendLocation)
                 {