Skip to content

Consider renaming Icon type to PhosphorIcon #134

@ajmnz

Description

@ajmnz

Following the v2.1.8 release that suffixed all icons with Icon, renaming the Icon type to PhosphorIcon would also contribute towards a better DX and more targeted suggestions. For example:

  • Import autocomplete for Icon is much more polluted than PhosphorIcon
  • It's way more readable and predictable when used as a React prop
interface Props {
  title: string;
  icon?: Icon; // what kind of Icon?
}

interface PropsV2 {
  title: string;
  icon?: PhopsphorIcon; // clear and concise
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions