Skip to content

Commit 6acacfc

Browse files
committed
chore: fix Windows CI build command and add security hardening
- Remove invalid GCC flags (/fPIC -shared) that MSVC silently ignored - Fix output path from -o to /Fe notation (the DLL was not landing in dist/) - Add /sdl /guard:cf /Qspectre /ZH:SHA_256 (compiler) and /DYNAMICBASE /NXCOMPAT /guard:cf /CETCOMPAT (linker)
1 parent ef37f94 commit 6acacfc

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
shell: bash
5050
- run: make sqlite-vec.h
5151
- run: mkdir dist
52-
- run: cl.exe /fPIC -shared /W4 /Ivendor/ /O2 /LD sqlite-vec.c -o dist/vec0.dll
52+
- run: cl.exe /W4 /sdl /guard:cf /Qspectre /ZH:SHA_256 /Ivendor/ /O2 /LD sqlite-vec.c /Fedist/vec0.dll /link /DYNAMICBASE /NXCOMPAT /guard:cf /CETCOMPAT
5353
- uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
5454
with:
5555
name: sqlite-vec-windows-x86_64-extension

0 commit comments

Comments
 (0)