Fix phpunit 8 compat to unlock testing Symfony on PHP 7.4 (#102)

Author: nicolas-grekas

composer.json

@@ -30,7 +30,8 @@
     "require-dev": {
         "phpunit/phpunit": "^4.8.35|^5.4.3",
         "cache/cache": "^1.0",
-        "symfony/cache": "^3.1|^4.0|^5.0",
+        "symfony/cache": "^3.4.31|^4.3.4|^5.0",
+        "symfony/phpunit-bridge": "^4.4",
         "illuminate/cache": "^5.4|^5.5|^5.6",
         "tedivm/stash": "^0.14",
         "mockery/mockery": "^1.0"

src/CachePoolTest.php

@@ -14,9 +14,12 @@
 use PHPUnit\Framework\TestCase;
 use Psr\Cache\CacheItemInterface;
 use Psr\Cache\CacheItemPoolInterface;
+use Symfony\Bridge\PhpUnit\ForwardCompatTestTrait;
 
 abstract class CachePoolTest extends TestCase
 {
+    use ForwardCompatTestTrait;
+
     /**
      * @type array with functionName => reason.
      */
@@ -32,12 +35,12 @@ abstract class CachePoolTest extends TestCase
      */
     abstract public function createCachePool();
 
-    protected function setUp()
+    private function doSetUp()
     {
         $this->cache = $this->createCachePool();
     }
 
-    protected function tearDown()
+    private function doTearDown()
     {
         if ($this->cache !== null) {
             $this->cache->clear();

src/HierarchicalCachePoolTest.php

@@ -13,12 +13,15 @@
 
 use PHPUnit\Framework\TestCase;
 use Psr\Cache\CacheItemPoolInterface;
+use Symfony\Bridge\PhpUnit\ForwardCompatTestTrait;
 
 /**
  * @author Tobias Nyholm <tobias.nyholm@gmail.com>
  */
 abstract class HierarchicalCachePoolTest extends TestCase
 {
+    use ForwardCompatTestTrait;
+
     /**
      * @type array with functionName => reason.
      */
@@ -34,12 +37,12 @@ abstract class HierarchicalCachePoolTest extends TestCase
      */
     abstract public function createCachePool();
 
-    protected function setUp()
+    private function doSetUp()
     {
         $this->cache = $this->createCachePool();
     }
 
-    protected function tearDown()
+    private function doTearDown()
     {
         if ($this->cache !== null) {
             $this->cache->clear();

src/SimpleCacheTest.php

@@ -13,9 +13,12 @@
 
 use PHPUnit\Framework\TestCase;
 use Psr\SimpleCache\CacheInterface;
+use Symfony\Bridge\PhpUnit\ForwardCompatTestTrait;
 
 abstract class SimpleCacheTest extends TestCase
 {
+    use ForwardCompatTestTrait;
+
     /**
      * @type array with functionName => reason.
      */
@@ -46,12 +49,12 @@ public function advanceTime($seconds)
         sleep($seconds);
     }
 
-    protected function setUp()
+    private function doSetUp()
     {
         $this->cache = $this->createSimpleCache();
     }
 
-    protected function tearDown()
+    private function doTearDown()
     {
         if ($this->cache !== null) {
             $this->cache->clear();

src/TaggableCachePoolTest.php

@@ -13,12 +13,15 @@
 
 use Cache\TagInterop\TaggableCacheItemPoolInterface;
 use PHPUnit\Framework\TestCase;
+use Symfony\Bridge\PhpUnit\ForwardCompatTestTrait;
 
 /**
  * @author Tobias Nyholm <tobias.nyholm@gmail.com>
  */
 abstract class TaggableCachePoolTest extends TestCase
 {
+    use ForwardCompatTestTrait;
+
     /**
      * @type array with functionName => reason.
      */
@@ -34,12 +37,12 @@ abstract class TaggableCachePoolTest extends TestCase
      */
     abstract public function createCachePool();
 
-    protected function setUp()
+    private function doSetUp()
     {
         $this->cache = $this->createCachePool();
     }
 
-    protected function tearDown()
+    private function doTearDown()
     {
         if ($this->cache !== null) {
             $this->cache->clear();