Merge pull request #225 from ndossche/fix-224

rtheunissen · web-flow · commit c0bb65316f8d · 2026-03-11T15:04:30.000-07:00
Fix #224: Segfault while using Ds\Set
diff --git a/src/common.c b/src/common.c
@@ -157,9 +157,9 @@ void smart_str_appendz(smart_str *buffer, zval *value)
             return;
     }
 
-    zend_string *str = zval_get_string(value);
+    zend_string *str = zval_get_string_func(value);
     smart_str_append(buffer, str);
-    zend_string_free(str);
+    zend_string_release_ex(str, false);
 }
 
 zend_string *ds_join_zval_buffer(

Original file line number	Diff line number	Diff line change
`@@ -157,9 +157,9 @@ void smart_str_appendz(smart_str buffer, zval value)`
`157`	`157`	`return;`
`158`	`158`	`}`
`159`	`159`
`160`		`- zend_string *str = zval_get_string(value);`
	`160`	`+ zend_string *str = zval_get_string_func(value);`
`161`	`161`	`smart_str_append(buffer, str);`
`162`		`- zend_string_free(str);`
	`162`	`+ zend_string_release_ex(str, false);`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`zend_string *ds_join_zval_buffer(`