Skip to content

Commit 0e4b416

Browse files
committed
Remove unused PHP bundle API
1 parent e527d50 commit 0e4b416

8 files changed

Lines changed: 23 additions & 245 deletions

File tree

.gitattributes

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
11
* text=auto
22
/.github/ export-ignore
33
/docs/ export-ignore
4-
/tests/ export-ignore
54
/.editorconfig export-ignore
65
/.gitattributes export-ignore
76
/.gitignore export-ignore
87
/.php-cs-fixer.dist.php export-ignore
9-
/phpunit.xml export-ignore
10-
/.phpunit.result.cache export-ignore
118
/AGENTS.md export-ignore
129
/README.md export-ignore

.github/workflows/tests.yml

Lines changed: 10 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,6 @@ on:
99
- reopened
1010
workflow_dispatch:
1111
inputs:
12-
max-outdated:
13-
description: Maximum number of outdated packages allowed by the dependencies command.
14-
required: false
15-
type: number
16-
default: -1
17-
min-coverage:
18-
description: Minimum line coverage percentage enforced by dev-tools tests.
19-
required: false
20-
type: number
21-
default: 0
2212
publish-required-statuses:
2313
description: Mirror required test matrix checks as commit statuses for workflow-dispatched runs.
2414
required: false
@@ -49,27 +39,21 @@ jobs:
4939
uses: shivammathur/setup-php@v2
5040
with:
5141
php-version: ${{ matrix.php-version }}
52-
extensions: pcov, pcntl
53-
coverage: pcov
54-
55-
- name: Install global dev-tools
56-
run: |
57-
composer global config --no-plugins allow-plugins.ergebnis/composer-normalize true
58-
composer global config --no-plugins allow-plugins.fast-forward/dev-tools true
59-
composer global config --no-plugins allow-plugins.phpdocumentor/shim true
60-
composer global config --no-plugins allow-plugins.phpro/grumphp-shim true
61-
composer global config --no-plugins allow-plugins.pyrech/composer-changelogs true
62-
composer global require fast-forward/dev-tools:dev-main --with-all-dependencies --no-progress --no-interaction
63-
composer global config --no-plugins allow-plugins.fast-forward/dev-tools false
42+
coverage: none
6443

6544
- name: Install dependencies
6645
run: composer install --prefer-dist --no-progress --no-interaction
6746

6847
- name: Validate composer metadata
6948
run: composer validate --strict
7049

71-
- name: Run PHPUnit tests
72-
run: composer dev-tools tests -- --coverage=.dev-tools/coverage --min-coverage=${{ inputs.min-coverage || 0 }}
50+
- name: Validate packaged payload
51+
run: |
52+
test -d .agents/agents
53+
test -d .agents/skills
54+
test -f .agents/agents/issue-implementer.md
55+
test -f .agents/skills/github-pull-request/SKILL.md
56+
php -r '$composer = json_decode(file_get_contents("composer.json"), true, flags: JSON_THROW_ON_ERROR); if (($composer["type"] ?? null) !== "fast-forward-resource-bundle") { exit(1); } if (($composer["extra"]["installer-name"] ?? null) !== "agents") { exit(1); } if (($composer["extra"]["fast-forward-bundle"]["installer-path"] ?? null) !== ".agents/{\$name}/") { exit(1); }'
7357
7458
- name: Publish required test status
7559
if: ${{ always() && inputs.publish-required-statuses }}
@@ -82,10 +66,10 @@ jobs:
8266
run: |
8367
if [ "${TEST_RESULT}" = "success" ]; then
8468
state="success"
85-
description="Workflow-dispatched PHPUnit job passed."
69+
description="Workflow-dispatched package validation job passed."
8670
else
8771
state="failure"
88-
description="Workflow-dispatched PHPUnit job result: ${TEST_RESULT}."
72+
description="Workflow-dispatched package validation job result: ${TEST_RESULT}."
8973
fi
9074
9175
gh api \

AGENTS.md

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@
66
It carries reusable project-agent prompts under `.agents/agents/` and procedural
77
skills under `.agents/skills/`.
88

9-
This repository is intentionally content-first. Keep runtime PHP source limited
10-
to tiny metadata helpers such as `src/AgentBundle.php` unless a future issue
11-
explicitly expands the package contract.
9+
This repository is intentionally content-first. Do not add runtime PHP source
10+
unless a future issue explicitly expands the package contract.
1211

1312
## Setup Commands
1413

@@ -36,10 +35,8 @@ Important paths:
3635

3736
- `.agents/agents/` packaged role prompts for repository work.
3837
- `.agents/skills/` packaged procedural skills and their reference material.
39-
- `src/AgentBundle.php` constants for the Composer installer type and payload paths.
4038
- `composer.json` package metadata, custom Composer type, installer dependencies,
4139
and bundle path hints.
42-
- `tests/` validation for Composer metadata and expected payload layout.
4340
- `.github/workflows/` CI, changelog, label, review, and project automation.
4441

4542
Keep edits focused on agent content, skill instructions, metadata, or repository
@@ -52,13 +49,12 @@ Use the smallest relevant check while editing:
5249

5350
```bash
5451
composer validate --strict
55-
./vendor/bin/phpunit tests
5652
```
5753

58-
Run the global Fast Forward test wrapper before publishing a PR:
54+
Check changelog discipline on PR branches:
5955

6056
```bash
61-
composer dev-tools tests -- --coverage=.dev-tools/coverage --min-coverage=0
57+
composer dev-tools changelog:check -- --file=CHANGELOG.md --against=origin/main
6258
```
6359

6460
If `composer dev-tools` reports auto-fixable formatting or generated-output
@@ -77,13 +73,10 @@ for the installer-paths work tracked in `php-fast-forward/dev-tools#195`. Until
7773

7874
## Code Style
7975

80-
Keep documentation, agent prompts, skill files, and tests in English. Preserve
81-
the existing Fast Forward markdown structure and avoid rewriting copied skill
76+
Keep documentation, agent prompts, and skill files in English. Preserve the
77+
existing Fast Forward markdown structure and avoid rewriting copied skill
8278
references unless the standalone package layout requires it.
8379

84-
For PHP test files, keep `declare(strict_types=1);`, the repository header, and
85-
PHPUnit attributes consistent with other Fast Forward packages.
86-
8780
## Pull Request Guidelines
8881

8982
Do not push implementation work directly to `main`. Use one issue-focused branch

README.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,15 @@ assuming they live inside the `dev-tools` archive.
6464

6565
- `.agents/agents/` contains project-agent prompts.
6666
- `.agents/skills/` contains reusable procedural skills and reference material.
67-
- `FastForward\Agents\AgentBundle` exposes the resource-bundle type and payload path
68-
constants used by tests and future integration work.
6967

7068
The copied payload is intentionally kept close to the current `dev-tools`
7169
version. Content changes should stay minimal unless they are required for the
7270
standalone bundle layout.
7371

72+
The Composer metadata in `composer.json` is the package contract. This package
73+
does not expose a runtime PHP API yet; one can be introduced later when
74+
`dev-tools` has a concrete integration need.
75+
7476
## Development
7577

7678
Install dependencies:
@@ -87,17 +89,16 @@ composer global require fast-forward/dev-tools:dev-main
8789
composer global config --no-plugins allow-plugins.fast-forward/dev-tools false
8890
```
8991

90-
Validate the package metadata and payload shape:
92+
Validate the package metadata:
9193

9294
```bash
9395
composer validate --strict
94-
./vendor/bin/phpunit tests
9596
```
9697

97-
Run the global Fast Forward test wrapper before opening a PR:
98+
Check changelog discipline on PR branches:
9899

99100
```bash
100-
composer dev-tools tests -- --coverage=.dev-tools/coverage --min-coverage=0
101+
composer dev-tools changelog:check -- --file=CHANGELOG.md --against=origin/main
101102
```
102103

103104
The root package intentionally does not require `fast-forward/dev-tools` as a

composer.json

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -41,20 +41,7 @@
4141
"composer/installers": "^2.3",
4242
"oomphinc/composer-installers-extender": "^2.0"
4343
},
44-
"require-dev": {
45-
"phpunit/phpunit": "^12.5 || ^13.0"
46-
},
4744
"minimum-stability": "stable",
48-
"autoload": {
49-
"psr-4": {
50-
"FastForward\\Agents\\": "src/"
51-
}
52-
},
53-
"autoload-dev": {
54-
"psr-4": {
55-
"FastForward\\Agents\\Tests\\": "tests/"
56-
}
57-
},
5845
"config": {
5946
"allow-plugins": {
6047
"composer/installers": true,

phpunit.xml

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/AgentBundle.php

Lines changed: 0 additions & 51 deletions
This file was deleted.

tests/ComposerMetadataTest.php

Lines changed: 0 additions & 116 deletions
This file was deleted.

0 commit comments

Comments
 (0)