refactor(commands): simplify command execution and update input handling

Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>

Author: coisa

src/Command/AbstractCommand.php

@@ -21,8 +21,7 @@
 use RuntimeException;
 use Symfony\Component\Console\Helper\ProcessHelper;
 use Composer\Command\BaseCommand;
-use Symfony\Component\Console\Input\ArrayInput;
-use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Input\StringInput;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\Filesystem\Path;
@@ -181,27 +180,17 @@ protected function getDevToolsFile(string $filename): string
     /**
      * Configures and executes a registered console command by name.
      *
-     * The method MUST look up the command from the application and run it. It SHALL ignore generic
-     * validation errors and route the custom input and output correctly.
+     * The method MUST run the specified command with the provided input and output interfaces.
      *
-     * @param string $commandName the name of the required command
-     * @param array|InputInterface $input the input arguments or array definition
+     * @param string $command the commandline name of the command to execute
      * @param OutputInterface $output the interface for buffering output
      *
      * @return int the status code resulting from the dispatched command
      */
-    protected function runCommand(string $commandName, array|InputInterface $input, OutputInterface $output): int
+    protected function runCommand(string $command, OutputInterface $output): int
     {
-        $application = $this->getApplication();
-
-        $command = $application->find($commandName);
-        $command->ignoreValidationErrors();
-
-        if (\is_array($input)) {
-            $input = new ArrayInput($input);
-        }
-
-        return $command->run($input, $output);
+        return $this->getApplication()
+            ->doRun(new StringInput($command), $output);
     }
 
     /**

src/Command/ReportsCommand.php

@@ -65,14 +65,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $results = [];
 
         $output->writeln('<info>Generating API documentation on path: ' . $docsPath . '</info>');
-        $results[] = $this->runCommand('docs', [
-            '--target' => $docsPath,
-        ], $output);
+        $results[] = $this->runCommand('docs --target=' . $docsPath, $output);
 
         $output->writeln('<info>Generating test coverage report on path: ' . $coveragePath . '</info>');
-        $results[] = $this->runCommand('tests', [
-            '--coverage' => $coveragePath,
-        ], $output);
+        $results[] = $this->runCommand('tests --coverage=' . $coveragePath, $output);
 
         $output->writeln('<info>Frontpage generation completed!</info>');
 

src/Command/StandardsCommand.php

@@ -70,10 +70,12 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $results = [];
 
-        $results[] = $this->runCommand('refactor', $input, $output);
-        $results[] = $this->runCommand('phpdoc', $input, $output);
-        $results[] = $this->runCommand('code-style', $input, $output);
-        $results[] = $this->runCommand('reports', $input, $output);
+        $fix = $input->getOption('fix') ? '--fix' : '';
+
+        $results[] = $this->runCommand('refactor ' . $fix, $output);
+        $results[] = $this->runCommand('phpdoc ' . $fix, $output);
+        $results[] = $this->runCommand('code-style ' . $fix, $output);
+        $results[] = $this->runCommand('reports', $output);
 
         $output->writeln('<info>All code standards checks completed!</info>');
 

src/Command/SyncCommand.php

@@ -21,7 +21,6 @@
 use Composer\Factory;
 use Composer\Json\JsonManipulator;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\StringInput;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Filesystem\Path;
 use Symfony\Component\Finder\Finder;
@@ -75,7 +74,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $this->copyEditorConfig();
         $this->copyDependabotConfig();
         $this->addRepositoryWikiGitSubmodule();
-        $this->syncGitIgnore($output);
+        $this->runCommand('gitignore', $output);
 
         return self::SUCCESS;
     }
@@ -235,20 +234,4 @@ private function getGitRepositoryUrl(): string
 
         return trim($process->getOutput());
     }
-
-    /**
-     * Synchronizes .gitignore entries from dev-tools into the target project.
-     *
-     * This method merges canonical .gitignore entries from the dev-tools package
-     * with the target project's existing .gitignore entries, then writes the merged result.
-     *
-     * @param OutputInterface $output
-     *
-     * @return void
-     */
-    private function syncGitIgnore(OutputInterface $output): void
-    {
-        $this->getApplication()
-            ->doRun(new StringInput('gitignore'), $output);
-    }
 }