[tests] Fix no-logo option handling and assertions

Author: coisa

src/Console/DevTools.php

@@ -47,8 +47,6 @@
  */
 final class DevTools extends Application
 {
-    private const string NO_LOGO_OPTION = 'no-logo';
-
     private const string LOGO = <<<'LOGO'
          ____             _____           _
         |  _ \  _____   _|_   _|__   ___ | |___
@@ -57,6 +55,8 @@ final class DevTools extends Application
         |____/ \___| \_/   |_|\___/ \___/|_|___/
         LOGO;
 
+    private const string NO_LOGO_OPTION = 'no-logo';
+
     /**
      * @var ContainerInterface holds the static container instance for global access within the DevTools context
      */
@@ -89,16 +89,6 @@ public function __construct(
         $this->setCommandLoader($commandLoader);
     }
 
-    /**
-     * Gets the help message for the DevTools application.
-     *
-     */
-    #[Override]
-    public function getHelp(): string
-    {
-        return parent::getHelp();
-    }
-
     /**
      * Returns the application-level input definition with DevTools runtime options.
      *
@@ -130,7 +120,7 @@ protected function getDefaultInputDefinition(): InputDefinition
         ));
 
         $definition->addOption(new InputOption(
-            name: self::NO_LOGO_OPTION,
+            name: 'no-logo',
             mode: InputOption::VALUE_NONE,
             description: 'Hide the startup ASCII logo.',
         ));
@@ -149,7 +139,9 @@ protected function getDefaultInputDefinition(): InputDefinition
     #[Override]
     public function doRun(InputInterface $input, OutputInterface $output): int
     {
-        if (! (bool) $input->getOption(self::NO_LOGO_OPTION)) {
+        $noLogo = (bool) $input->getParameterOption('--no-logo', null, true);
+
+        if (! $noLogo) {
             $output->writeln(self::LOGO);
         }
 
@@ -162,7 +154,7 @@ public function doRun(InputInterface $input, OutputInterface $output): int
             return Command::FAILURE;
         }
 
-        if (! $this->isSelfUpdateCommand($input)) {
+        if (! $noLogo && ! $this->isSelfUpdateCommand($input)) {
             $this->runAutoUpdateWhenRequested($input, $output);
             $this->versionCheckNotifier->notify($output);
         }

src/Process/ProcessBuilder.php

@@ -121,21 +121,14 @@ private function shouldAddLogoSuppressionArgument(array $command): bool
             return false;
         }
 
-        if (0 === \count($command)) {
+        if ([] === $command) {
             return false;
         }
 
-        $binary = \str_replace('\\', '/', $command[0]);
-        $packageBinaryPath = \str_replace('\\', '/', DevToolsPathResolver::getBinaryPath());
-
-        return $binary === $packageBinaryPath
-            || \str_starts_with($binary, 'vendor/bin/dev-tools')
-            || \str_starts_with($binary, './vendor/bin/dev-tools')
-            || \str_starts_with($binary, 'bin/dev-tools')
-            || \str_starts_with($binary, './bin/dev-tools')
-            || \str_ends_with($binary, '/vendor/bin/dev-tools')
-            || \str_ends_with($binary, '/vendor/fast-forward/dev-tools/bin/dev-tools')
-            || \str_ends_with($binary, '/bin/dev-tools');
+        $binary = str_replace('\\', '/', $command[0]);
+        $packageBinaryPath = str_replace('\\', '/', DevToolsPathResolver::getBinaryPath());
+
+        return $binary === $packageBinaryPath;
     }
 
     /**
@@ -145,11 +138,11 @@ private function shouldAddLogoSuppressionArgument(array $command): bool
      */
     private function prependLogoSuppressionArgument(array $command): array
     {
-        if (0 === \count($command)) {
+        if ([] === $command) {
             return $command;
         }
 
-        $binary = \array_shift($command);
+        $binary = array_shift($command);
 
         return [$binary, self::NO_LOGO_ARGUMENT, ...$command];
     }

tests/Console/DevToolsTest.php

@@ -218,7 +218,7 @@ public function constructorWillRegisterGlobalRuntimeOptions(): void
         self::assertSame('w', $definition->getOption('workspace-dir')->getShortcut());
         self::assertTrue($definition->hasOption('auto-update'));
         self::assertTrue($definition->hasOption('no-logo'));
-        self::assertFalse($definition->getOption('no-logo')->acceptsValue());
+        self::assertFalse($definition->getOption('no-logo')->acceptValue());
     }
 
     /**