Skip to content

Commit 965fa8b

Browse files
committed
[dependencies] Update max-outdated default value to -1 and remove run-dependencies-check input
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
1 parent b1cf195 commit 965fa8b

2 files changed

Lines changed: 5 additions & 23 deletions

File tree

.github/workflows/tests.yml

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,33 +8,23 @@ on:
88
required: false
99
type: number
1010
default: 80
11-
run-dependencies-check:
12-
description: Whether to run the dependency health check during CI.
13-
required: false
14-
type: boolean
15-
default: true
1611
max-outdated:
1712
description: Maximum number of outdated packages allowed by the dependencies command.
1813
required: false
1914
type: number
20-
default: 5
15+
default: -1
2116
workflow_dispatch:
2217
inputs:
2318
min-coverage:
2419
description: Minimum line coverage percentage enforced by dev-tools tests.
2520
required: false
2621
type: number
2722
default: 80
28-
run-dependencies-check:
29-
description: Whether to run the dependency health check during CI.
30-
required: false
31-
type: boolean
32-
default: true
3323
max-outdated:
3424
description: Maximum number of outdated packages allowed by the dependencies command.
3525
required: false
3626
type: number
37-
default: 5
27+
default: -1
3828
pull_request:
3929
paths:
4030
- 'src/**'
@@ -126,9 +116,7 @@ jobs:
126116
dependency-health:
127117
needs: resolve_php
128118
name: Dependency Health
129-
if: ${{ github.event_name != 'workflow_call' || inputs.run-dependencies-check }}
130119
runs-on: ubuntu-latest
131-
continue-on-error: true
132120
env:
133121
TESTS_ROOT_VERSION: ${{ github.event_name == 'pull_request' && format('dev-{0}', github.event.pull_request.head.ref) || 'dev-main' }}
134122
FORCE_COLOR: '1'
@@ -162,4 +150,4 @@ jobs:
162150
- name: Run dependency health check
163151
env:
164152
COMPOSER_ROOT_VERSION: ${{ env.TESTS_ROOT_VERSION }}
165-
run: composer dev-tools dependencies -- --max-outdated=${{ inputs.max-outdated || 5 }}
153+
run: composer dev-tools dependencies -- --max-outdated=${{ inputs.max-outdated || -1 }}

resources/github-actions/tests.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,11 @@ on:
44
push:
55
workflow_dispatch:
66
inputs:
7-
run-dependencies-check:
8-
description: Whether to run the dependency health check during CI.
9-
required: false
10-
type: boolean
11-
default: true
127
max-outdated:
138
description: Maximum number of outdated packages allowed by the dependencies command.
149
required: false
1510
type: number
16-
default: 5
11+
default: -1
1712

1813
permissions:
1914
contents: read
@@ -22,6 +17,5 @@ jobs:
2217
tests:
2318
uses: php-fast-forward/dev-tools/.github/workflows/tests.yml@main
2419
with:
25-
run-dependencies-check: ${{ inputs.run-dependencies-check || true }}
26-
max-outdated: ${{ inputs.max-outdated || 5 }}
20+
max-outdated: ${{ inputs.max-outdated || -1 }}
2721
secrets: inherit

0 commit comments

Comments
 (0)