fix: avoid registering command aliases in composer provider

Author: coisa

src/Composer/Capability/DevToolsCommandProvider.php

@@ -22,22 +22,37 @@
 use Composer\Plugin\Capability\CommandProvider;
 use FastForward\DevTools\Composer\Command\ProxyCommand;
 use FastForward\DevTools\Console\DevTools;
-use Symfony\Component\Console\Command\Command;
 
 /**
  * Provides a registry of custom dev-tools commands mapped for Composer integration.
  * This capability struct MUST implement the defined `CommandProvider`.
  */
 final class DevToolsCommandProvider implements CommandProvider
 {
+    /**
+     * @var string the namespace prefix for dev-tools console commands to be registered as Composer commands
+     */
+    private const string COMMAND_NAMESPACE = 'FastForward\DevTools\Console\Command';
+
     /**
      * {@inheritDoc}
      */
     public function getCommands()
     {
-        return array_map(
-            static fn(Command $command): ProxyCommand => new ProxyCommand($command),
-            iterator_to_array(DevTools::create()->getCommands()),
-        );
+        $commands = [];
+
+        foreach (DevTools::create()->all() as $registeredName => $command) {
+            if ($registeredName !== $command->getName()) {
+                continue;
+            }
+
+            if (! str_starts_with($command::class, self::COMMAND_NAMESPACE)) {
+                continue;
+            }
+
+            $commands[] = new ProxyCommand($command);
+        }
+
+        return $commands;
     }
 }

src/Console/DevTools.php

@@ -53,13 +53,12 @@ final class DevTools extends Application
      *
      * @param CommandLoaderInterface $commandLoader the command loader responsible for providing command instances
      */
-    public function __construct(
-        private readonly CommandLoaderInterface $commandLoader
-    ) {
+    public function __construct(CommandLoaderInterface $commandLoader)
+    {
         parent::__construct('Fast Forward Dev Tools');
 
-        $this->setDefaultCommand('standards');
-        $this->setCommandLoader($this->commandLoader);
+        $this->setDefaultCommand('dev-tools:standards');
+        $this->setCommandLoader($commandLoader);
     }
 
     /**
@@ -73,18 +72,6 @@ public function getHelp(): string
         return self::LOGO . "\n\n" . parent::getHelp();
     }
 
-    /**
-     * Retrieves the shared DevTools service container.
-     *
-     * @return iterable
-     */
-    public function getCommands(): iterable
-    {
-        foreach ($this->commandLoader->getNames() as $name) {
-            yield $name => $this->commandLoader->get($name);
-        }
-    }
-
     /**
      * Create DevTools instance from container.
      *

tests/Composer/Capability/DevToolsCommandProviderTest.php

@@ -57,7 +57,7 @@ protected function setUp(): void
             ->willReturn($this->devTools->reveal())
             ->shouldBeCalledOnce();
 
-        $this->devTools->getCommands()
+        $this->devTools->all()
             ->willReturn([])->shouldBeCalledOnce();
 
         $this->commandProvider = new DevToolsCommandProvider();
@@ -90,8 +90,10 @@ public function getCommandsWillReturnComposerProxyCommandsForRegisteredSymfonyCo
         $symfonyCommand->setHelp('');
         $symfonyCommand->setHidden(false);
 
-        $this->devTools->getCommands()
-            ->willReturn([$symfonyCommand])
+        $this->devTools->all()
+            ->willReturn([
+                'agents' => $symfonyCommand,
+            ])
             ->shouldBeCalledOnce();
 
         $commands = $this->commandProvider->getCommands();

tests/Console/CommandLoader/DevToolsCommandLoaderTest.php

@@ -108,7 +108,7 @@ public function constructorWillRegisterOnlyInstantiableCommands(): void
      * @return void
      */
     #[Test]
-    public function constructorWillRegisterCommandAliasesFromAsCommandAttribute(): void
+    public function constructorWillRegisterPrimaryCommandFromAsCommandAttribute(): void
     {
         $commandDirectory = \dirname(__DIR__, 3) . '/src/Console/Command';
 
@@ -134,7 +134,6 @@ public function constructorWillRegisterCommandAliasesFromAsCommandAttribute(): v
         $loader = new DevToolsCommandLoader($this->finderFactory->reveal(), $this->container->reveal());
 
         self::assertTrue($loader->has('dev-tools:sync'));
-        self::assertTrue($loader->has('sync'));
     }
 
     /**