Skip to content

Commit e3b59c6

Browse files
[agents] Refine review skill wiki-state handling (#147) (#174)
* [agents] Teach review skill about wiki workflow state * [agents] Refine review skill wiki-state handling (#147) * Update wiki submodule pointer for PR #174 * [agents] Guard follow-up PR flow against closed branches * [changelog] Clarify agent follow-up guard entry (#147) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 7cbf5b5 commit e3b59c6

9 files changed

Lines changed: 29 additions & 2 deletions

File tree

.agents/agents/issue-implementer.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ pull request.
1919
## Responsibilities
2020

2121
- Resolve issue and branch context before editing code.
22+
- Check whether any earlier PR for the issue or branch is already closed
23+
before assuming prior branch names are safe to reuse.
2224
- Keep the diff focused on the selected issue.
2325
- Run the smallest relevant verification first, then the broader gate when
2426
warranted.
@@ -34,6 +36,8 @@ pull request.
3436
## Boundaries
3537

3638
- Do not batch unrelated issues into the same branch or PR.
39+
- Do not revive a deleted historical branch for follow-up work; prefer opening
40+
a bug issue and starting a fresh branch/PR.
3741
- Do not skip verification before publishing a PR update.
3842
- Do not guess through vague acceptance criteria when the issue is not
3943
actionable enough to implement safely.

.agents/agents/review-guardian.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ and generated-output drift before human review time is spent.
2525
- Treat packaged skills, project agents, workflow wrappers, local actions,
2626
changelog entries, wiki output, and generated reports as first-class review
2727
surfaces when touched.
28+
- Treat ``.github/wiki`` pointer changes as workflow-managed state when they
29+
line up with wiki preview or wiki maintenance automation, rather than as
30+
automatic evidence of accidental scope creep.
2831
- Stay reusable across this repository and consumer repositories that
2932
synchronize DevTools assets.
3033

.agents/skills/github-pull-request/SKILL.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ Use this skill to take a Fast Forward issue from "ready to implement" to an open
2020
- Keep one branch and one PR per issue.
2121
- Branch from `main` or the repository integration branch, never from another feature branch.
2222
- When returning to `main` before starting a new implementation, always fetch and fast-forward from the remote before creating the next feature branch so release files, changelog state, and generated artifacts start from the latest published baseline.
23+
- Before pushing or reopening prior work, verify whether an earlier PR for the
24+
issue or branch is already closed. If the earlier branch has been deleted or
25+
the PR is closed, prefer opening a follow-up bug issue and publishing a new
26+
branch and PR instead of reviving the old branch name.
2327
- Prefer local `git` for checkout, commit, and push.
2428
- Prefer connector-backed GitHub data for issue and PR context when available.
2529
- Use `phpunit-tests`, `package-readme`, and `sphinx-docs` when the change clearly affects tests or documentation.
@@ -41,6 +45,9 @@ Use this skill to take a Fast Forward issue from "ready to implement" to an open
4145

4246
- Do not batch unrelated issues into one branch or PR.
4347
- Do not create a duplicate PR if the current branch already has one.
48+
- Do not push new follow-up work onto a previously closed PR branch that has
49+
already been deleted upstream; open a bug issue and start a fresh branch/PR
50+
instead.
4451
- Do not open a PR before running the relevant verification commands.
4552
- Do not skip a notable changelog update when the implementation changes public behavior, release automation, or repository workflows in a way users or maintainers would expect to see called out.
4653
- Do not proceed to the next issue if the repository is dirty from unfinished work.

.agents/skills/github-pull-request/references/context-routing.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,5 @@ Before starting implementation, confirm:
3434
- the base branch exists locally and can be updated
3535
- the issue is specific enough to implement
3636
- authentication for the required GitHub operations is available if a PR will be opened
37+
- any earlier PR tied to the intended branch or issue is still open before
38+
treating that branch as reusable

.agents/skills/github-pull-request/references/pr-drafting.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ Before creating a new PR, check whether the current branch already has an open P
88

99
- If a PR already exists, update it instead of creating a duplicate.
1010
- If no PR exists, create one against `main` or the repository's integration branch.
11+
- If an earlier PR for the same issue or historical branch already exists but
12+
is closed, do not assume that branch should be reused. When the old branch
13+
was deleted or the previous PR represents finished work, open a follow-up
14+
bug issue and publish a fresh branch and PR.
1115

1216
## Template Rule
1317

.agents/skills/pull-request-review/SKILL.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@ possible.
3535
- Treat ``.github/workflows``, ``resources/github-actions``, ``.github/actions``,
3636
``.agents/skills``, ``.agents/agents``, ``README.md``, ``docs/``,
3737
``CHANGELOG.md``, and ``.github/wiki`` as high-signal review surfaces.
38+
- When ``.github/wiki`` moves, verify whether the wiki preview or wiki
39+
maintenance workflow is expected to refresh the submodule pointer before
40+
treating that change as unrelated drift or scope creep.
3841
- Prefer precise repository file references in every finding.
3942
- Review what changed, but reason about downstream consumer impact when the PR
4043
touches packaged assets or synchronized defaults.

.agents/skills/pull-request-review/references/surface-priorities.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ Additional Fast Forward review surfaces
2222

2323
- ``README.md`` and ``docs/`` for onboarding, command, or workflow drift.
2424
- ``CHANGELOG.md`` for notable user-facing or automation-facing changes.
25-
- ``.github/wiki`` when generated wiki output is touched.
25+
- ``.github/wiki`` when generated wiki output is touched. In this repository,
26+
the wiki preview and wiki maintenance workflows can legitimately move the
27+
submodule pointer as workflow-managed state, so confirm whether the change
28+
matches that automation before flagging it as unrelated drift.
2629
- ``resources/`` when synchronized templates or packaged defaults changed.
2730

2831
Typical review questions

.github/wiki

Submodule wiki updated from c1c3fa7 to e4312aa

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1313

1414
### Changed
1515

16+
- Teach the review and pull-request agent skills to treat workflow-managed wiki pointer updates as expected state and to prefer fresh follow-up issues plus PRs over reviving closed deleted branches (#147)
1617
- Require GitHub issue write readback verification in the github-issues skill (#165)
1718
- Standardize cache flags and nested cache-dir propagation across cache-aware commands (#162)
1819

0 commit comments

Comments
 (0)