[refactor] Integrate Type Perfect into the refactor workflow (#9)#101
Closed
[refactor] Integrate Type Perfect into the refactor workflow (#9)#101
Conversation
Contributor
|
🚀 Preview is available for this pull request. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in Type Perfect pass to
composer dev-tools refactorso consumer projects can run Rector and Type Perfect as part of the same refactoring workflow without hand-building a dedicated PHPStan config.Changes
--type-perfectand--type-perfect-groupstoRefactorCommandtmp/cache/phpstan/type-perfect.neon, automatically including localphpstan.neonorphpstan.neon.distwhen presentrector/type-perfectandphpstan/extension-installerTesting
./vendor/bin/phpunit tests/Console/Command/RefactorCommandTest.php- passed./vendor/bin/phpunit tests/Console/Command- passed (78 tests, 291 assertions); the known JoliNotif runner warning still appears at the endgit diff --check- passedcomposer dev-tools- not reliable in this environment because parallel tool steps hit local socket restrictions (Failed to listen on tcp://127.0.0.1:0: EPERM) and Composer network resolution failed for Packagist (curl error 6)Closes #9