[composer] Restore consumer command discovery compatibility (#185)#198
Merged
[composer] Restore consumer command discovery compatibility (#185)#198
Conversation
e5a6be1 to
15e6f10
Compare
Contributor
|
🚀 Preview is available for this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #185
Motivation / Context
agentssilently skipped packaged top-level.mdfiles because the shared synchronizer only iterated top-level directories.skillsandagentssync.Changes
#[AsCommand(...)]attributes and intoconfigure()so discovery no longer depends on the unsupportedhelp:named parametersuggestedValues:named argument fromChangelogEntryCommandFastForward\DevTools\Filesystem\Filesystemfrom inheritance to composition so it no longer conflicts with the Symfony Filesystem shipped inside Composercomposer agentsnow links packaged agent Markdown prompts in consumer repositoriestests/Fixtures/composer-plugin-consumer/so we can exercise command discovery through the Composer plugin using a path repositoryVerification
composer dev-tools./vendor/bin/phpunit tests/Filesystem/FilesystemTest.php tests/Console/Command/CommandAttributeCompatibilityTest.php tests/Console/Command/CopyResourceCommandTest.php tests/Console/Command/UpdateComposerJsonCommandTest.php tests/Console/Command/CodeOwnersCommandTest.php tests/Console/Command/GitHooksCommandTest.php tests/Console/Command/FundingCommandTest.php tests/Console/Command/LicenseCommandTest.php tests/Console/Command/GitIgnoreCommandTest.php tests/Console/Command/GitAttributesCommandTest.php tests/Console/Command/ChangelogEntryCommandTest.php./vendor/bin/phpunit tests/Filesystem/FilesystemTest.php tests/Sync/PackagedDirectorySynchronizerTest.php tests/Console/Command/AgentsCommandTest.phpcomposer dev-tools changelog:checkgit diff --checkcd tests/Fixtures/composer-plugin-consumer && composer install --no-interactioncd tests/Fixtures/composer-plugin-consumer && composer agents --helprm -rf tests/Fixtures/composer-plugin-consumer/.agents/agents tests/Fixtures/composer-plugin-consumer/.agents/skills && mkdir -p tests/Fixtures/composer-plugin-consumer/.agents/agents tests/Fixtures/composer-plugin-consumer/.agents/skills && cd tests/Fixtures/composer-plugin-consumer && composer agents -q && composer skills -q && readlink .agents/agents/issue-editor.md && readlink .agents/skills/changelog-generatorDocumentation / Generated Output
docs/updatedChangelog
CHANGELOG.mdentryReviewer Notes
.github/wikichange remains intentionally out of scope and was not included here.composer.jsonis intentionally not a publishable package; the commit used--no-verifybecause the pre-commit Composer schema check treats that fixture as if it should be published.