[process] Stop forcing PTY for queued processes (#171)#229
Merged
Conversation
Contributor
|
🚀 Preview is available for this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #171
Motivation / Context
reports,standards, anddev-tools:fixenqueue nested DevTools subprocesses.ProcessQueuewas enabling PTY on every queued process whenever Symfony reported PTY support, which still fails in non-interactive runners without/dev/tty.Changes
setPty(true)fromProcessQueue::add().Verification
composer dev-tools./vendor/bin/phpunit tests/Process/ProcessQueueTest.phpcomposer dev-tools tests -- --filter='ProcessQueue' --no-cachecomposer dev-tools tests -- --filter='Process' --no-cachecomposer dev-tools code-style -- --fix --jsoncomposer dev-tools phpdoc -- --json --no-cachecomposer dev-tools refactor -- --jsoncomposer dev-tools changelog:checkgit diff --checkreportsfailure before the fix (proc_open(/dev/tty): Failed to open stream: Device not configured). After removing forced PTY,reportsandstandardsadvanced into their nested child commands without the/dev/ttyfailure; the local run was interrupted once it reached the longphpmetricsstage.composer dev-toolswas not completed end-to-end locally because the full gate enters the longreports -> metricspath in this shell; the original immediate/dev/ttyfailure is no longer reproduced.Documentation / Generated Output
docs/updatedNo generated docs/wiki output was committed.
Changelog
CHANGELOG.mdentryReviewer Notes