Skip to content

[agents] Teach review workflow validation#242

Merged
coisa merged 3 commits intomainfrom
fix/241-review-workflow-validation
Apr 24, 2026
Merged

[agents] Teach review workflow validation#242
coisa merged 3 commits intomainfrom
fix/241-review-workflow-validation

Conversation

@coisa
Copy link
Copy Markdown
Contributor

@coisa coisa commented Apr 24, 2026

Related Issue

Closes #241

Motivation / Context

  • PR [ci] Auto-resolve predictable PR conflicts #237 surfaced a workflow-review gap: bot-authored commits pushed with GITHUB_TOKEN need explicit required-check dispatch or mirroring.
  • The review skill and review-guardian agent should preserve that premise for future workflow/action changes instead of relying on reviewer memory.

Changes

  • Added workflow-action-validation.md to the pull-request review skill references.
  • Updated $pull-request-review to require executable validation strategies for workflow, local-action, and packaged-wrapper changes.
  • Updated review-guardian responsibilities with the same workflow validation expectations.
  • Updated the review request action brief so automatically requested reviews highlight validation evidence, bot-authored commits, and required-check mirroring.
  • Added a changelog entry.

Verification

  • composer dev-tools
  • composer dev-tools code-style -- --fix --json
  • composer dev-tools changelog:check
  • node --check .github/actions/review/render-request/run.cjs
  • Mocked render-request/run.cjs execution and verified generated comment/summary include workflow validation guidance
  • git diff --check

Documentation / Generated Output

  • README updated
  • docs/ updated (packaged skill/agent guidance updated; no Sphinx docs needed)
  • Generated or synchronized output reviewed

Changelog

  • Added a notable CHANGELOG.md entry

Reviewer Notes

  • This intentionally updates the existing review skill/agent rather than introducing a separate skill yet. The new reference is isolated so we can split it later if it grows.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

@coisa coisa merged commit 60a6b76 into main Apr 24, 2026
32 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Released in PHP Fast Forward Project Apr 24, 2026
@coisa coisa deleted the fix/241-review-workflow-validation branch April 24, 2026 18:47
github-actions Bot added a commit that referenced this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request github-actions

Projects

Status: Released

Development

Successfully merging this pull request may close these issues.

Teach review agents to validate workflow and action changes explicitly

1 participant