-
-
Notifications
You must be signed in to change notification settings - Fork 0
Support workflow consumers without a local DevTools dependency #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5528e56
Support workflow consumers without local DevTools
coisa b9702f6
Fix workflow runtime resolution for repository checkouts
coisa 0dc32af
Fix workflow runtime resolution and CLI invocations
coisa 9cf5128
Update wiki submodule pointer for PR #307
github-actions[bot] 1fa24cc
Validate local DevTools runtime package metadata
coisa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
.github/actions/php/setup-composer/detect-dev-tools-runtime.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| source "$(dirname "$0")/dev-tools-runtime-lib.sh" | ||
|
|
||
| resolve_dev_tools_runtime | ||
|
|
||
| needs_fallback='false' | ||
|
|
||
| if runtime_requires_workflow_fallback; then | ||
| needs_fallback='true' | ||
| fi | ||
|
|
||
| { | ||
| printf 'source=%s\n' "${DEV_TOOLS_RUNTIME_SOURCE}" | ||
| printf 'needs-fallback=%s\n' "${needs_fallback}" | ||
| printf 'binary=%s\n' "${DEV_TOOLS_RUNTIME_BINARY}" | ||
| printf 'autoload=%s\n' "${DEV_TOOLS_RUNTIME_AUTOLOAD}" | ||
| printf 'source-directory=%s\n' "${DEV_TOOLS_SOURCE_DIRECTORY}" | ||
| } >> "${GITHUB_OUTPUT}" |
93 changes: 93 additions & 0 deletions
93
.github/actions/php/setup-composer/dev-tools-runtime-lib.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| resolve_dev_tools_workspace_path() { | ||
| local input_path="${1:-.}" | ||
|
|
||
| if [[ "${input_path}" = /* ]]; then | ||
| printf '%s\n' "${input_path}" | ||
|
|
||
| return | ||
| fi | ||
|
|
||
| printf '%s/%s\n' "$(pwd)" "${input_path#./}" | ||
| } | ||
|
|
||
| workspace_is_dev_tools_repository() { | ||
| local workspace_root="${1:?Workspace root is required}" | ||
| local composer_json="${workspace_root}/composer.json" | ||
|
|
||
| if [ ! -f "${composer_json}" ]; then | ||
| return 1 | ||
| fi | ||
|
|
||
| php -r ' | ||
| $composer = json_decode((string) file_get_contents($argv[1]), true); | ||
|
|
||
| if (! is_array($composer)) { | ||
| exit(1); | ||
| } | ||
|
|
||
| exit(($composer["name"] ?? null) === "fast-forward/dev-tools" ? 0 : 1); | ||
| ' "${composer_json}" | ||
| } | ||
|
|
||
| resolve_dev_tools_runtime() { | ||
| local source_directory_input="${INPUT_DEV_TOOLS_SOURCE_DIRECTORY:-.dev-tools-actions}" | ||
|
|
||
| DEV_TOOLS_WORKSPACE_ROOT="$(pwd)" | ||
| DEV_TOOLS_SOURCE_DIRECTORY="$(resolve_dev_tools_workspace_path "${source_directory_input}")" | ||
| DEV_TOOLS_LOCAL_AUTOLOAD="${DEV_TOOLS_WORKSPACE_ROOT}/vendor/autoload.php" | ||
| DEV_TOOLS_LOCAL_INSTALLED_BINARY="${DEV_TOOLS_WORKSPACE_ROOT}/vendor/bin/dev-tools" | ||
| DEV_TOOLS_LOCAL_REPOSITORY_BINARY="${DEV_TOOLS_WORKSPACE_ROOT}/bin/dev-tools" | ||
|
|
||
| if [ -x "${DEV_TOOLS_LOCAL_INSTALLED_BINARY}" ] && [ -f "${DEV_TOOLS_LOCAL_AUTOLOAD}" ]; then | ||
| DEV_TOOLS_RUNTIME_SOURCE='local' | ||
| DEV_TOOLS_RUNTIME_BINARY="${DEV_TOOLS_LOCAL_INSTALLED_BINARY}" | ||
| DEV_TOOLS_RUNTIME_AUTOLOAD="${DEV_TOOLS_LOCAL_AUTOLOAD}" | ||
|
|
||
| return 0 | ||
| fi | ||
|
|
||
| if [ -x "${DEV_TOOLS_LOCAL_REPOSITORY_BINARY}" ] && [ -f "${DEV_TOOLS_LOCAL_AUTOLOAD}" ] && workspace_is_dev_tools_repository "${DEV_TOOLS_WORKSPACE_ROOT}"; then | ||
| DEV_TOOLS_RUNTIME_SOURCE='local' | ||
| DEV_TOOLS_RUNTIME_BINARY="${DEV_TOOLS_LOCAL_REPOSITORY_BINARY}" | ||
| DEV_TOOLS_RUNTIME_AUTOLOAD="${DEV_TOOLS_LOCAL_AUTOLOAD}" | ||
|
|
||
| return 0 | ||
| fi | ||
|
|
||
| if [ ! -d "${DEV_TOOLS_SOURCE_DIRECTORY}" ]; then | ||
| echo "The DevTools workflow source directory was not found: ${DEV_TOOLS_SOURCE_DIRECTORY}" >&2 | ||
|
|
||
| return 1 | ||
| fi | ||
|
|
||
| if ! workspace_is_dev_tools_repository "${DEV_TOOLS_SOURCE_DIRECTORY}"; then | ||
| echo "The DevTools workflow source directory does not point to the fast-forward/dev-tools package: ${DEV_TOOLS_SOURCE_DIRECTORY}" >&2 | ||
| echo "Checkout the full php-fast-forward/dev-tools source into ${source_directory_input} before using this action." >&2 | ||
|
|
||
| return 1 | ||
| fi | ||
|
|
||
| DEV_TOOLS_RUNTIME_SOURCE='workflow' | ||
| DEV_TOOLS_RUNTIME_BINARY="${DEV_TOOLS_SOURCE_DIRECTORY}/bin/dev-tools" | ||
| DEV_TOOLS_RUNTIME_AUTOLOAD="${DEV_TOOLS_SOURCE_DIRECTORY}/vendor/autoload.php" | ||
| } | ||
|
|
||
| runtime_requires_workflow_fallback() { | ||
| [ "${DEV_TOOLS_RUNTIME_SOURCE}" = 'workflow' ] | ||
| } | ||
|
|
||
| ensure_resolved_runtime_is_available() { | ||
| if [ ! -x "${DEV_TOOLS_RUNTIME_BINARY}" ]; then | ||
| echo "Resolved DevTools binary is not executable: ${DEV_TOOLS_RUNTIME_BINARY}" >&2 | ||
|
|
||
| return 1 | ||
| fi | ||
|
|
||
| if [ ! -f "${DEV_TOOLS_RUNTIME_AUTOLOAD}" ]; then | ||
| echo "Resolved DevTools autoload file was not found: ${DEV_TOOLS_RUNTIME_AUTOLOAD}" >&2 | ||
|
|
||
| return 1 | ||
| fi | ||
| } | ||
36 changes: 36 additions & 0 deletions
36
.github/actions/php/setup-composer/expose-dev-tools-runtime.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| source "$(dirname "$0")/dev-tools-runtime-lib.sh" | ||
|
|
||
| resolve_dev_tools_runtime | ||
| ensure_resolved_runtime_is_available | ||
|
|
||
| runtime_directory="${RUNNER_TEMP:-${TMPDIR:-/tmp}}/dev-tools-runtime/bin" | ||
| wrapper_path="${runtime_directory}/dev-tools" | ||
|
|
||
| mkdir -p "${runtime_directory}" | ||
|
|
||
| { | ||
| printf '#!/usr/bin/env bash\n' | ||
| printf 'set -euo pipefail\n' | ||
| printf 'exec %q "$@"\n' "${DEV_TOOLS_RUNTIME_BINARY}" | ||
| } > "${wrapper_path}" | ||
|
|
||
| chmod +x "${wrapper_path}" | ||
|
|
||
| { | ||
| printf 'DEV_TOOLS_BINARY=%s\n' "${DEV_TOOLS_RUNTIME_BINARY}" | ||
| printf 'DEV_TOOLS_AUTOLOAD=%s\n' "${DEV_TOOLS_RUNTIME_AUTOLOAD}" | ||
| printf 'DEV_TOOLS_AUTO_RESOLVE_AUTOLOAD=%s\n' "${DEV_TOOLS_RUNTIME_AUTOLOAD}" | ||
| printf 'DEV_TOOLS_RUNTIME_SOURCE=%s\n' "${DEV_TOOLS_RUNTIME_SOURCE}" | ||
| } >> "${GITHUB_ENV}" | ||
|
|
||
| printf '%s\n' "${runtime_directory}" >> "${GITHUB_PATH}" | ||
|
|
||
| { | ||
| printf 'binary=%s\n' "${DEV_TOOLS_RUNTIME_BINARY}" | ||
| printf 'autoload=%s\n' "${DEV_TOOLS_RUNTIME_AUTOLOAD}" | ||
| printf 'source=%s\n' "${DEV_TOOLS_RUNTIME_SOURCE}" | ||
| printf 'command=%s\n' "${wrapper_path}" | ||
| } >> "${GITHUB_OUTPUT}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.