refactor: reorganize commands into Console namespace with dependency injection#42
Merged
refactor: reorganize commands into Console namespace with dependency injection#42
Conversation
- Simplified command instantiation in CopyLicenseCommandTest and DocsCommandTest. - Improved test structure and readability in GitAttributesCommandTest and PhpDocCommandTest. - Updated ReportsCommandTest to remove unnecessary command mocks. - Enhanced TestsCommandTest and WikiCommandTest with ComposerJson mocking. - Introduced ComposerJsonTest to validate ComposerJson accessors and behavior. - Added DevToolsCommandLoaderTest to ensure only instantiable commands are registered. - Refactored DevToolsTest to utilize CommandLoaderInterface for command management. - Enhanced PlaceholderResolverTest and ReaderTest with ClockInterface for date handling. - Added JoliNotifExecutionFinishedSubscriberTest to validate notification behavior on test execution. - Introduced SystemClockTest to verify current date-time retrieval. - Added ContainerTest to validate static container behavior and configuration loading. Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
… for dependency injection Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
…ServiceProvider documentation Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
…er, SystemClock, and DevToolsServiceProvider classes Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
…ibutesCommand constructor Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
…nizer constructor Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
…lass Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/Command/tosrc/Console/Command/ComposerJsondependency to commands that need itDevTools,CommandLoader)Changes
Namespace Changes
FastForward\DevTools\Command\*→FastForward\DevTools\Console\Command\*FastForward\DevTools\Console\*FastForward\DevTools\Psr\*New Dependencies
ComposerJsonadded to commands that need to read composer.jsonDocumentation Updates
Note
Some tests need additional updates to match new command constructors. Tests that need updating will fail until adapted.
Closes #41