[DevTools] Migrate from phpro/grumphp to phpro/grumphp-shim (#43)#44
Merged
[DevTools] Migrate from phpro/grumphp to phpro/grumphp-shim (#43)#44
Conversation
Replaces direct dependency with no-dependency metapackage to avoid transitive dependency conflicts in downstream projects. Closes #43
- Add composer, composer_normalize, jsonlint, yamllint, phplint tasks for pre-commit validation - Add parallel execution support - Create post-checkout and post-merge hooks for vendor synchronization Closes #43
- Update post-checkout and post-merge hooks to check composer.lock - Add copyGitHooks method to SyncCommand for vendor synchronization - Simplify grumphp.yml config by removing unavailable tasks Refs #43
fix(post-merge): update hook to run composer update for modified composer.json Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
…ation Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates from
phpro/grumphptophpro/grumphp-shimto eliminate dependency resolution conflicts in downstream projects. The shim is a no-dependency metapackage that provides the GrumPHP executable without forcing specific transitive dependency versions.Changes
phpro/grumphpwithphpro/grumphp-shimincomposer.jsonrequire sectionallow-pluginsconfiguration to reference the shim packagegrumphp.ymlunchangedTesting
composer installcompletes successfully with grumphp-shimdev-toolsvalidation as expectedNote: The additional enhancements for post-checkout and post-merge hooks (to synchronize vendor state when switching branches) are not included in this PR because GrumPHP v2.x native git hooks are limited to pre-commit and pre-push. This can be addressed separately with custom git hooks.
Closes #43