[git-hooks] Make packaged hooks canonical (#92)#93
Merged
Conversation
Contributor
|
🚀 Preview is available for this pull request. |
… hook installation commands. Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
…e ENV variable. Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pre-commitandcommit-msghook templates underresources/git-hooks.post-checkoutandpost-mergeto refresh dependencies whencomposer.jsonorcomposer.lockchanges.DEVTOOLS_*context variables from post-checkout and post-merge hooks.GitHooksCommandso it only copies/chmods packaged hooks and no longer runsgrumphp git:init.--skip-grumphp-initbehavior.Verification
rg -n "BASE_DIR|skip-grumphp-init|grumphp git:init|hooks_dir" . --glob '!vendor/**' --glob '!tmp/**'sh -n resources/git-hooks/commit-msg && sh -n resources/git-hooks/pre-commit && sh -n resources/git-hooks/post-checkout && sh -n resources/git-hooks/post-mergegit diff --check./vendor/bin/phpunit --filter GitHooksCommandTest(blocked:env: php: No such file or directory)./vendor/bin/phpunit --filter 'FilesystemTest::symlinkAndReadlinkWillUseAbsolutePaths'(blocked:env: php: No such file or directory)Notes
BASE_DIR,hooks_dir,grumphp.yml,.gitattributes, orupdate-composer-jsonchanges are included.Closes #92