Replace xml with php config#484
Conversation
Orest-Divintari
force-pushed
the
orest/replace-xml-with-php-config
branch
2 times, most recently
from
153c95d to
dbab283
Compare
Convert all service configuration files from deprecated XML format to PHP format to eliminate Symfony deprecation warnings and for Symfony 8.0 compatibility.
Orest-Divintari
force-pushed
the
orest/replace-xml-with-php-config
branch
from
dbab283 to
8b1d3fe
Compare
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
thanks a lot, this looks good, and the tests agree.
why did you mark it as draft? are you trying it out in some real application?
Thanks, No, it was late at night and wanted to review it myself before I ask you to review it. |
|
@dbu Thanks for the quick merge! Would you mind tagging it ? 🙏 |
|
i'd love to include sf 8 support in the release. but #483 fails with weird errors - if you have any inputs/ideas what could be the issue, i'd love inputs as i don't have any more ideas what it could be. |
|
I agree it be nice to have intermediate patch release, so we can proceed testing a deprecation-free sf 7.4 release |
|
fair enough - and i don't have time to dig into the issue with symfony 8 right now. so here you go: https://github.com/php-http/HttplugBundle/releases/tag/2.2.0 |
4 participants
What's in this PR?
It replaces xml config with php config.
Why?
Because Symfony 7.4 has deprecated xml config
Checklist