Skip to content

Ref #291 - setOption(Memcached::OPT_PREFIX_KEY => false) should return false#292

Closed
SjonHortensius wants to merge 1 commit into
php-memcached-dev:masterfrom
SjonHortensius:master
Closed

Ref #291 - setOption(Memcached::OPT_PREFIX_KEY => false) should return false#292
SjonHortensius wants to merge 1 commit into
php-memcached-dev:masterfrom
SjonHortensius:master

Conversation

@SjonHortensius

Copy link
Copy Markdown

No description provided.

@sodabrew

Copy link
Copy Markdown
Collaborator

The tests seem to disagree with the expectation:

========DIFF========
013+ bool(true)
013- 
014- Warning: Memcached::setOptions(): error setting memcached option: %s in %s on line %d
015- bool(false)
========DONE========
FAIL Set options using setOptions [tests/setoptions.phpt] 

@SjonHortensius

SjonHortensius commented Jan 20, 2017

Copy link
Copy Markdown
Author

I added this test to demonstrate that setOption(prefix, somethingincorrect) is broken since it should return false; but actually returns true.

To make this test succeed; the setOption needs to be fixed

@SjonHortensius

Copy link
Copy Markdown
Author

I actually think this is fixed by #294; which casts somethingincorrect to an empty string implicitly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants