Skip to content

re-add 64bits tests (skipped on 32bits)#320

Closed
remicollet wants to merge 1 commit into
php-memcached-dev:masterfrom
remicollet:issue-tests
Closed

re-add 64bits tests (skipped on 32bits)#320
remicollet wants to merge 1 commit into
php-memcached-dev:masterfrom
remicollet:issue-tests

Conversation

@remicollet

Copy link
Copy Markdown
Collaborator

I also add the skipif.inc which was obviously missing in the archvie.

Comment thread package.xml
<file role='src' name='fastlz/fastlz.c'/>
<file role='src' name='fastlz/fastlz.h'/>
<dir name="tests">
<file role='test' name='skipif.inc'/>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@sodabrew

sodabrew commented Feb 9, 2017

Copy link
Copy Markdown
Collaborator

Thanks very much for moving quickly to address my concern! I put together a smaller test set in #320 and want to check in with you before I move on one or the other of the PRs.

@sodabrew sodabrew modified the milestone: 3.0.2 Feb 9, 2017
@sodabrew sodabrew mentioned this pull request Feb 9, 2017
@sodabrew

Copy link
Copy Markdown
Collaborator

Thank you! Using smaller #321.

@sodabrew sodabrew closed this Feb 10, 2017
@remicollet remicollet deleted the issue-tests branch February 10, 2017 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants