Skip to content

Separate test for 64-bit increment/decrement/incrementByKey/decrementByKey#321

Merged
sodabrew merged 1 commit into
php-memcached-dev:masterfrom
sodabrew:tests_incrdecr_64
Feb 10, 2017
Merged

Separate test for 64-bit increment/decrement/incrementByKey/decrementByKey#321
sodabrew merged 1 commit into
php-memcached-dev:masterfrom
sodabrew:tests_incrdecr_64

Conversation

@sodabrew

@sodabrew sodabrew commented Feb 9, 2017

Copy link
Copy Markdown
Collaborator

#320 beat me to it :)

@sodabrew sodabrew modified the milestone: 3.0.2 Feb 9, 2017
@sodabrew sodabrew mentioned this pull request Feb 9, 2017
@remicollet

remicollet commented Feb 9, 2017

Copy link
Copy Markdown
Collaborator

The die message MUST start with "skip ", else the test if never skipped"...

TEST 37/82 [tests/incrdecr_64.phpt]
========DIFF========
004+ 
005+ Warning: Memcached::increment() expects parameter 2 to be integer, float given in /builddir/build/BUILD/php-pecl-memcached-3.0.1/ZTS/tests/incrdecr_64.php on line 10
006+ int(1)
007+ 
008+ Warning: Memcached::decrement() expects parameter 2 to be integer, float given in /builddir/build/BUILD/php-pecl-memcached-3.0.1/ZTS/tests/incrdecr_64.php on line 13
004- int(4294967297)
007- int(4294967297)
011+ 
012+ Warning: Memcached::incrementByKey() expects parameter 3 to be integer, float given in /builddir/build/BUILD/php-pecl-memcached-3.0.1/ZTS/tests/incrdecr_64.php on line 17
013+ int(1)
014+ 
015+ Warning: Memcached::decrementByKey() expects parameter 3 to be integer, float given in /builddir/build/BUILD/php-pecl-memcached-3.0.1/ZTS/tests/incrdecr_64.php on line 20
========DONE========
FAIL 64-bit Memcached::increment() decrement() incrementByKey() decrementByKey() [tests/incrdecr_64.phpt] 

@sodabrew

sodabrew commented Feb 9, 2017

Copy link
Copy Markdown
Collaborator Author

Updated. Thanks for pointing out the "skip " message requirement!

@remicollet

Copy link
Copy Markdown
Collaborator

Tested on :

  • RHEL-7, x86_64, PHP 7.1
  • RHEL-6, i686, PHP 7.0

LGTM
even if when you have 64, bit probably need a "s" ;)

@sodabrew sodabrew changed the title Separate test for 64-bit increment/decremenet/incrementByKey/decrementByKey Separate test for 64-bit increment/decrement/incrementByKey/decrementByKey Feb 9, 2017
@sodabrew

sodabrew commented Feb 9, 2017

Copy link
Copy Markdown
Collaborator Author

I think 64-bit vs. 64-bits might depend on which side of the Atlantic one computes on! :)

@sodabrew sodabrew merged commit 83d5f30 into php-memcached-dev:master Feb 10, 2017
@sodabrew sodabrew deleted the tests_incrdecr_64 branch February 10, 2017 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants