Move PhD auxiliary-file generation out to php/phd#318
Conversation
configure.php now only assembles and validates the XML. The generation of version.xml, sources.xml and fileModHistory.php is removed (phd_acronym, php_history, phd_sources, phd_version) and delegated to php/phd via a doc-base/temp/phd-conf.json handoff. Also fixes the --history-file option, which set SOURCES_FILE instead of HISTORY_FILE. Depends on php/phd (adds genphdfiles.php). The build pipeline must call 'php phd/genphdfiles.php doc-base/temp/phd-conf.json' before this lands.
|
Wow! That is exactly what I was thinking of. Paint me very impressed. The moved files are mentioned in |
version.xml, sources.xml and fileModHistory.php are now generated by PhD (genphdfiles.php), not by configure.php, so doc-base no longer produces them.
|
I think the doc-base side is ok. You can merge here at your earliest convenience, and yet, let this open a few days, for comments and/or reviews. I will do a heads up no Discord, to be sure. |
|
If the PhD side goes without indications of reviews or merging, then I will change this side, keep the hand-off file and PhD functions and merge in one week's time. These are some performance and doc-ext changes that are easier to do without worrying of git conflicts risk. |
|
As PhD side shows no sign of being merged, I tried to checkout, rebase and push directly into this PR, but failed. @lacatoire , please consider rebasing and hard reseting this into master HEAD, and then applying the changes of https://github.com/alfsb/doc-base/tree/pr318. |
2 participants
Following php/phd#253 (comment). configure.php now only assembles and validates the XML.
Removes the generation of version.xml, sources.xml and fileModHistory.php (phd_acronym, php_history, phd_sources, phd_version), writing a doc-base/temp/phd-conf.json handoff instead. Also fixes the --history-file option, which set SOURCES_FILE instead of HISTORY_FILE.
Companion: php/phd#261 (adds genphdfiles.php).
Do not merge before the build pipeline calls
php phd/genphdfiles.php doc-base/temp/phd-conf.json, otherwise the manual would build without version banners.