Skip to content

Fix text-entities statistics, clean ups #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alfsb wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −123
Open

Fix text-entities statistics, clean ups #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions entities/normal.ent-dist
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions entities/remove.ent-dist
View file
Open in desktop

This file was deleted.

37 changes: 0 additions & 37 deletions entities/unique.ent-dist
View file
Open in desktop

This file was deleted.

11 changes: 8 additions & 3 deletions scripts/revcheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,15 @@
exit;
}

$lang = $argv[1];
$revc = new RevcheckRun( 'en' , $argv[1] );
$data = $revc->revData;
$lang = rtrim( $argv[1] , "/" );
if ( $lang == 'en' )
{
print "{$argv[0]} cannot run on doc-en.\n";
exit( 1 );
}

$revc = new RevcheckRun( 'en' , $lang );
$data = $revc->revData;
print_html_all( $data );

// Output
Expand Down
32 changes: 16 additions & 16 deletions scripts/text-entities.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,48 +225,48 @@ static function checkReplaces( bool $debug )

foreach( Entities::$merged as $name => $null )
{
$replaced = Entities::$nameCount[$name] - 1;
$languages = Entities::$countLanguages;
$replaces = Entities::$nameCount[$name] - 1;
$translation = Entities::$countLanguages > 1;
$entityUnique = in_array( $name , Entities::$unique );
$entityRemove = in_array( $name , Entities::$remove );
$entityNormal = ! ( $entityUnique || $entityRemove );

if ( $entityUnique && $replaced != 0 )
if ( $entityUnique && $replaces != 0 )
{
Entities::$countOtherFailures++;
if ( $debug )
print " Unique entity, redefined $replaced times: $name\n";
print " Unique entity, redefined $replaces times: $name\n";
}

if ( $entityRemove && $replaced != 0 )
if ( $entityRemove && $replaces != 0 )
{
Entities::$countOtherFailures++;
if ( $debug )
print " Remove entity, redefined $replaced times: $name\n";
print " Remove entity, redefined $replaces times: $name\n";
}

if ( $entityNormal && $languages == 1 && $replaced != 0 )
if ( $entityNormal && $translation )
{
Entities::$countOtherFailures++;
if ( $debug )
print " Normal entity, redefined $replaced times: $name\n";
}

if ( $entityNormal && $languages != 1 )
{
if ( $replaced == 0 )
if ( $replaces == 0 )
{
Entities::$countTransFailures++;
if ( $debug )
print " Not translated: $name\n";
}
else
if ( $replaces > 1 )
{
Entities::$countOtherFailures++;
if ( $debug )
print " Multiple redefined/translated: $name\n";
}
}

if ( $entityNormal && ! $translation && $replaces != 0 )
{
Entities::$countOtherFailures++;
if ( $debug )
print " Multiple redefined/translated: $name\n";
}
}
}
}
Expand Down
Loading