Skip to content

Commit 8e89023

Browse files
authored
GH Actions: fail "setup-php" if requested tooling/extensions could not be installed (#5714)
Setup-PHP will normally "gracefully" show a warning and not fail the build when an extension or tool failed to install. In most cases, this is not particularly useful as that means that either there will be a failure later on in the build due to the extension or tool missing, or the build will not be representative of what is supposed to be run/tested. This commit changes this behaviour to fail the build at the `setup-php` step, which also makes debugging these type of build failures much more straight-forward. Ref: https://github.com/shivammathur/setup-php?tab=readme-ov-file#fail-fast-optional Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
1 parent 22ca944 commit 8e89023

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

.github/workflows/docbook-cs.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,8 @@ jobs:
7474
php-version: "8.5"
7575
extensions: "dom, libxml, simplexml"
7676
tools: composer, cs2pr
77+
env:
78+
fail-fast: true
7779

7880
- name: "Build documentation"
7981
run: |

0 commit comments

Comments
 (0)