Add deprecation/changelog for switch statement semicolons.#4895
Conversation
I find it appropriate. This what it's for. See also: https://www.php.net/manual/en/info.configuration.php#ini.assert.active where the snippet is used for various INIs. |
|
I'm not sure what to do with the changelog here. It seems like we're going to need to redo the whole file to allow it to use a section tag? That seems... scope creepy, but also a blocker. Please advise, someone who knows this better than I do. |
I'm not sure we need the changelog. I don't think this was previously done for similar pages / it was only done for functions. |
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Using the XML entity seems fine.
| </para> | ||
| <para> | ||
| It's possible to use a semicolon instead of a colon after a case like: | ||
| Prior to PHP 8.5.0, it was possible to use a semicolon instead of a colon after a case like: |
There was a problem hiding this comment.
But it is still possible, just deprecated.
There was a problem hiding this comment.
Hm. If we're adding the deprecation marker, should this line change at all?
There was a problem hiding this comment.
I guess the line can remain the same, makes also less work for translators.
Use sect2 Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
7 participants
I'm not sure if it makes sense to use the "deprecated" entities here, since it's just a tiny part of the syntax that's deprecated, not the whole thing. The "feature" warning seems like it would be overkill. So I just adjusted the text and added a changelog.