Skip to content

openssl_sign()'s new $padding parameter needs to be OPENSSL_PKCS1_PSS_PADDING for PSS padding to work #5420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
terrafrost wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

openssl_sign()'s new $padding parameter needs to be OPENSSL_PKCS1_PSS_PADDING for PSS padding to work #5420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion reference/openssl/functions/openssl-sign.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,10 @@
<varlistentry>
<term><parameter>padding</parameter></term>
<listitem>
<simpara>RSA PSS padding to use.</simpara>
<para>
Copy link
Copy Markdown
Contributor

@jordikroon jordikroon Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<para>
<simpara>

<parameter>padding</parameter> only supports one option:
<constant>OPENSSL_PKCS1_PSS_PADDING</constant>.
Comment on lines +75 to +76
Copy link
Copy Markdown
Member

@lacatoire lacatoire Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<parameter>padding</parameter> only supports one option:
<constant>OPENSSL_PKCS1_PSS_PADDING</constant>.
Controls RSA padding. If unspecified (<literal>0</literal>), the default RSA PKCS#1 v1.5 padding is used.
Set to <constant>OPENSSL_PKCS1_PSS_PADDING</constant> to enable PSS.

Copy link
Copy Markdown
Member

@lacatoire lacatoire Apr 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

php_openssl_setup_rsa_padding() accept 3 values (0 / RSA_PKCS1_PADDING / RSA_PKCS1_PSS_PADDING). Here

</para>
Copy link
Copy Markdown
Contributor

@jordikroon jordikroon Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</para>
</simpara>

</listitem>
</varlistentry>
</variablelist>
Expand Down