Skip to content

Commit 13071ff

Browse files
committed
fix copilot review
1 parent 3b9d226 commit 13071ff

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

internal/extgen/nsparser.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ type NamespaceParser struct{}
1313

1414
var namespaceRegex = regexp.MustCompile(`//\s*export_php:namespace\s+(.+)`)
1515

16-
func (np *NamespaceParser) parse(filename string) (string, error) {
16+
func (np *NamespaceParser) parse(filename string) (foundNamespace string, err error) {
1717
file, err := os.Open(filename)
1818
if err != nil {
1919
return "", err
@@ -23,9 +23,7 @@ func (np *NamespaceParser) parse(filename string) (string, error) {
2323
err = errors.Join(err, file.Close())
2424
}()
2525

26-
var foundNamespace string
27-
var lineNumber int
28-
var foundLineNumber int
26+
var lineNumber, foundLineNumber int
2927

3028
scanner := bufio.NewScanner(file)
3129
for scanner.Scan() {
@@ -36,6 +34,7 @@ func (np *NamespaceParser) parse(filename string) (string, error) {
3634
if foundNamespace != "" {
3735
return "", fmt.Errorf("multiple namespace declarations found: first at line %d, second at line %d", foundLineNumber, lineNumber)
3836
}
37+
3938
foundNamespace = namespace
4039
foundLineNumber = lineNumber
4140
}

0 commit comments

Comments
 (0)