Skip to content

Commit 1c9ab87

Browse files
committed
ci: ignore secrets-outside-env for DOCKERHUB_TOKEN
super-linter v8.6.0 ships zizmor 1.23.1, which predates the secrets-outside-env allowlist option (added in 1.24.0), so the zizmor.yaml allowlist is ignored. Use inline ignore comments as a temporary workaround.
1 parent f51693c commit 1c9ab87

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/docker.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ jobs:
130130
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
131131
with:
132132
username: ${{ vars.DOCKERHUB_USERNAME }}
133-
password: ${{ secrets.DOCKERHUB_TOKEN }}
133+
password: ${{ secrets.DOCKERHUB_TOKEN }} # zizmor: ignore[secrets-outside-env] TODO: drop once super-linter ships zizmor >=1.24.0, then the allowlist in zizmor.yaml takes over
134134
- name: Build
135135
id: build
136136
uses: docker/bake-action@v7
@@ -228,7 +228,7 @@ jobs:
228228
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
229229
with:
230230
username: ${{ vars.DOCKERHUB_USERNAME }}
231-
password: ${{ secrets.DOCKERHUB_TOKEN }}
231+
password: ${{ secrets.DOCKERHUB_TOKEN }} # zizmor: ignore[secrets-outside-env] TODO: drop once super-linter ships zizmor >=1.24.0, then the allowlist in zizmor.yaml takes over
232232
- name: Create manifest list and push
233233
working-directory: /tmp/metadata
234234
run: |

.github/workflows/static.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ jobs:
122122
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
123123
with:
124124
username: ${{ vars.DOCKERHUB_USERNAME }}
125-
password: ${{ secrets.DOCKERHUB_TOKEN }}
125+
password: ${{ secrets.DOCKERHUB_TOKEN }} # zizmor: ignore[secrets-outside-env] TODO: drop once super-linter ships zizmor >=1.24.0, then the allowlist in zizmor.yaml takes over
126126
- name: Set VERSION
127127
run: |
128128
if [ "${GITHUB_REF_TYPE}" == "tag" ]; then
@@ -290,7 +290,7 @@ jobs:
290290
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
291291
with:
292292
username: ${{ vars.DOCKERHUB_USERNAME }}
293-
password: ${{ secrets.DOCKERHUB_TOKEN }}
293+
password: ${{ secrets.DOCKERHUB_TOKEN }} # zizmor: ignore[secrets-outside-env] TODO: drop once super-linter ships zizmor >=1.24.0, then the allowlist in zizmor.yaml takes over
294294
- name: Build
295295
id: build
296296
uses: docker/bake-action@v7
@@ -403,7 +403,7 @@ jobs:
403403
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
404404
with:
405405
username: ${{ vars.DOCKERHUB_USERNAME }}
406-
password: ${{ secrets.DOCKERHUB_TOKEN }}
406+
password: ${{ secrets.DOCKERHUB_TOKEN }} # zizmor: ignore[secrets-outside-env] TODO: drop once super-linter ships zizmor >=1.24.0, then the allowlist in zizmor.yaml takes over
407407
- name: Create manifest list and push
408408
working-directory: /tmp/metadata
409409
run: |

0 commit comments

Comments
 (0)