Skip to content

Commit 2857012

Browse files
fix(extgen): emit parser warnings to stderr instead of stdout (#2374)
1 parent a1334b6 commit 2857012

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

internal/extgen/classparser.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ func (cp *classParser) parse(filename string) (classes []phpClass, err error) {
8787
}
8888

8989
if err := validator.validateClass(class); err != nil {
90-
fmt.Printf("Warning: Invalid class '%s': %v\n", class.Name, err)
90+
fmt.Fprintf(os.Stderr, "Warning: Invalid class '%s': %v\n", class.Name, err)
9191
continue
9292
}
9393

@@ -229,7 +229,7 @@ func (cp *classParser) parseMethods(filename string) (methods []phpClassMethod,
229229

230230
method, err := cp.parseMethodSignature(className, signature)
231231
if err != nil {
232-
fmt.Printf("Warning: Error parsing method signature %q: %v\n", signature, err)
232+
fmt.Fprintf(os.Stderr, "Warning: Error parsing method signature %q: %v\n", signature, err)
233233

234234
continue
235235
}
@@ -244,7 +244,7 @@ func (cp *classParser) parseMethods(filename string) (methods []phpClassMethod,
244244
}
245245

246246
if err := validator.validateTypes(phpFunc); err != nil {
247-
fmt.Printf("Warning: Method \"%s::%s\" uses unsupported types: %v\n", className, method.Name, err)
247+
fmt.Fprintf(os.Stderr, "Warning: Method \"%s::%s\" uses unsupported types: %v\n", className, method.Name, err)
248248

249249
continue
250250
}
@@ -272,7 +272,7 @@ func (cp *classParser) parseMethods(filename string) (methods []phpClassMethod,
272272
}
273273

274274
if err := validator.validateGoFunctionSignatureWithOptions(phpFunc, true); err != nil {
275-
fmt.Printf("Warning: Go method signature mismatch for '%s::%s': %v\n", currentMethod.ClassName, currentMethod.Name, err)
275+
fmt.Fprintf(os.Stderr, "Warning: Go method signature mismatch for '%s::%s': %v\n", currentMethod.ClassName, currentMethod.Name, err)
276276
currentMethod = nil
277277
continue
278278
}

internal/extgen/funcparser.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,19 +38,19 @@ func (fp *FuncParser) parse(filename string) (functions []phpFunction, err error
3838
signature := strings.TrimSpace(matches[1])
3939
phpFunc, err := fp.parseSignature(signature)
4040
if err != nil {
41-
fmt.Printf("Warning: Error parsing signature '%s': %v\n", signature, err)
41+
fmt.Fprintf(os.Stderr, "Warning: Error parsing signature '%s': %v\n", signature, err)
4242

4343
continue
4444
}
4545

4646
if err := validator.validateFunction(*phpFunc); err != nil {
47-
fmt.Printf("Warning: Invalid function '%s': %v\n", phpFunc.Name, err)
47+
fmt.Fprintf(os.Stderr, "Warning: Invalid function '%s': %v\n", phpFunc.Name, err)
4848

4949
continue
5050
}
5151

5252
if err := validator.validateTypes(*phpFunc); err != nil {
53-
fmt.Printf("Warning: Function '%s' uses unsupported types: %v\n", phpFunc.Name, err)
53+
fmt.Fprintf(os.Stderr, "Warning: Function '%s' uses unsupported types: %v\n", phpFunc.Name, err)
5454

5555
continue
5656
}
@@ -68,7 +68,7 @@ func (fp *FuncParser) parse(filename string) (functions []phpFunction, err error
6868
currentPHPFunc.GoFunction = goFunc
6969

7070
if err := validator.validateGoFunctionSignatureWithOptions(*currentPHPFunc, false); err != nil {
71-
fmt.Printf("Warning: Go function signature mismatch for %q: %v\n", currentPHPFunc.Name, err)
71+
fmt.Fprintf(os.Stderr, "Warning: Go function signature mismatch for %q: %v\n", currentPHPFunc.Name, err)
7272
currentPHPFunc = nil
7373

7474
continue

0 commit comments

Comments
 (0)