ci: factor FRANKENPHP_VERSION resolution and setup-php into composite actions

Author: dunglas

.github/actions/setup-php/action.yaml

@@ -0,0 +1,18 @@
+name: setup-php
+description: Setup PHP in ZTS + debug mode with FrankenPHP's standard configuration
+inputs:
+  php-version:
+    description: PHP version (e.g. "8.5")
+    required: true
+runs:
+  using: composite
+  steps:
+    - uses: shivammathur/setup-php@v2
+      with:
+        php-version: ${{ inputs.php-version }}
+        ini-file: development
+        coverage: none
+        tools: none
+      env:
+        phpts: ts
+        debug: true

.github/actions/version/action.yaml

@@ -0,0 +1,26 @@
+name: version
+description: Resolve FRANKENPHP_VERSION from the current ref (stripped tag name, with commit SHA fallback)
+inputs:
+  ref:
+    description: Optional ref override (e.g. tag name resolved by a prepare job for schedule/dispatch flows)
+    required: false
+    default: ""
+runs:
+  using: composite
+  steps:
+    - shell: bash
+      env:
+        REF: ${{ inputs.ref }}
+      run: | # zizmor: ignore[github-env]
+        if [ "${GITHUB_REF_TYPE}" = "tag" ]; then
+          version="${GITHUB_REF_NAME#v}"
+        elif [ -n "${REF}" ]; then
+          version="${REF#v}"
+        else
+          version="${GITHUB_SHA}"
+        fi
+        if [[ ! "${version}" =~ ^[A-Za-z0-9._-]+$ ]]; then
+          echo "::error::invalid FRANKENPHP_VERSION value: ${version}" >&2
+          exit 1
+        fi
+        echo "FRANKENPHP_VERSION=${version}" >> "${GITHUB_ENV}"

.github/workflows/pgo-profile.yaml

@@ -36,15 +36,9 @@ jobs:
           # persist-credentials is intentionally left enabled because this
           # workflow needs to push a branch via git push (mirrors translate.yaml).
       - uses: ./.github/actions/setup-go
-      - uses: shivammathur/setup-php@v2
+      - uses: ./.github/actions/setup-php
         with:
           php-version: "8.5"
-          ini-file: development
-          coverage: none
-          tools: none
-        env:
-          phpts: ts
-          debug: true
       - name: Install e-dant/watcher
         uses: ./.github/actions/watcher
       - name: Set CGO flags

.github/workflows/static.yaml

@@ -453,19 +453,9 @@ jobs:
           ref: ${{ needs.prepare.outputs.ref }}
           persist-credentials: false
       - uses: ./.github/actions/setup-go
-      - name: Set FRANKENPHP_VERSION
-        run: |
-          if [ "${GITHUB_REF_TYPE}" == "tag" ]; then
-            export FRANKENPHP_VERSION=${GITHUB_REF_NAME:1}
-          elif [ "${GITHUB_EVENT_NAME}" == "schedule" ]; then
-            export FRANKENPHP_VERSION="${REF}"
-          else
-            export FRANKENPHP_VERSION=${GITHUB_SHA}
-          fi
-
-          echo "FRANKENPHP_VERSION=${FRANKENPHP_VERSION}" >> "${GITHUB_ENV}"
-        env:
-          REF: ${{ needs.prepare.outputs.ref }}
+      - uses: ./.github/actions/version
+        with:
+          ref: ${{ needs.prepare.outputs.ref }}
       - name: Build FrankenPHP
         run: ./build-static.sh
         env:

.github/workflows/tests.yaml

@@ -42,15 +42,9 @@ jobs:
         with:
           persist-credentials: false
       - uses: ./.github/actions/setup-go
-      - uses: shivammathur/setup-php@v2
+      - uses: ./.github/actions/setup-php
         with:
           php-version: ${{ matrix.php-versions }}
-          ini-file: development
-          coverage: none
-          tools: none
-        env:
-          phpts: ts
-          debug: true
       - name: Install e-dant/watcher
         uses: ./.github/actions/watcher
       - name: Reinstall libbrotli-dev
@@ -113,15 +107,9 @@ jobs:
         with:
           persist-credentials: false
       - uses: ./.github/actions/setup-go
-      - uses: shivammathur/setup-php@v2
+      - uses: ./.github/actions/setup-php
         with:
           php-version: ${{ matrix.php-versions }}
-          ini-file: development
-          coverage: none
-          tools: none
-        env:
-          phpts: ts
-          debug: true
       - name: Install PHP development libraries
         run: sudo apt-get update && sudo apt-get install -y libkrb5-dev libsodium-dev libargon2-dev
       - name: Install xcaddy
@@ -152,15 +140,9 @@ jobs:
         with:
           persist-credentials: false
       - uses: ./.github/actions/setup-go
-      - uses: shivammathur/setup-php@v2
+      - uses: ./.github/actions/setup-php
         with:
-          php-version: 8.5
-          ini-file: development
-          coverage: none
-          tools: none
-        env:
-          phpts: ts
-          debug: true
+          php-version: "8.5"
       - name: Install gotestsum
         run: go install gotest.tools/gotestsum@latest
       - name: Set CGO flags

.github/workflows/windows.yaml

@@ -69,23 +69,9 @@ jobs:
           path: frankenphp
           persist-credentials: false
 
-      - name: Set FRANKENPHP_VERSION
-        run: |
-          $ref = $env:REF
-
-          if ($env:GITHUB_REF_TYPE -eq "tag") {
-            $frankenphpVersion = $env:GITHUB_REF_NAME.Substring(1)
-          } elseif ($ref) {
-            if ($ref.StartsWith("v")) {
-              $frankenphpVersion = $ref.Substring(1)
-            } else {
-              $frankenphpVersion = $ref
-            }
-          } else {
-            $frankenphpVersion = $env:GITHUB_SHA
-          }
-
-          "FRANKENPHP_VERSION=$frankenphpVersion" >> $env:GITHUB_ENV
+      - uses: ./frankenphp/.github/actions/version
+        with:
+          ref: ${{ env.REF }}
 
       - name: Setup Go
         uses: ./frankenphp/.github/actions/setup-go