Skip to content

Commit 7ff9480

Browse files
authored
ci: fix lint failures blocking main (#2496)
Main is red on the Lint Code Base job for two deterministic reasons. ## clang-format `frankenphp.c:141` — the empty `while` body must sit on its own line. ## zizmor `github-app` zizmor 1.26 added the `github-app` audit, which flags `actions/create-github-app-token` invocations that inherit blanket installation permissions. Scoped the release app token (`dunglas-release`) to what it actually uses: - `contents: write` — commits, tags, refs, GitHub releases - `actions: write` — `gh workflow run` dispatch of downstream builds (static/docker/windows) Both verified locally: `zizmor` reports no findings, `clang-format --dry-run --Werror` is clean.
1 parent d0c8ca2 commit 7ff9480

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/release.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ jobs:
4949
with:
5050
app-id: ${{ vars.RELEASE_APP_ID }}
5151
private-key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }}
52+
permission-contents: write
53+
permission-actions: write
5254
- uses: actions/checkout@v6
5355
with:
5456
fetch-depth: 0

frankenphp.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,8 @@ static void *frankenphp_parent_death_watcher(void *arg) {
138138
_exit(1);
139139
}
140140
struct kevent event;
141-
while (kevent(kq, NULL, 0, &event, 1, NULL) < 0 && errno == EINTR);
141+
while (kevent(kq, NULL, 0, &event, 1, NULL) < 0 && errno == EINTR)
142+
;
142143
_exit(1);
143144
}
144145
#endif

0 commit comments

Comments
 (0)