fix(caddy): reject invalid split_path at provision time

alexandre-daubois · alexandre-daubois · commit a12b498fba71 · 2026-04-17T10:32:41.000+02:00
diff --git a/caddy/module.go b/caddy/module.go
@@ -117,11 +117,11 @@ func (f *FrankenPHPModule) Provision(ctx caddy.Context) error {
 		f.SplitPath = []string{".php"}
 	}
 
-	if opt, err := frankenphp.WithRequestSplitPath(f.SplitPath); err == nil {
-		f.requestOptions = append(f.requestOptions, opt)
-	} else {
-		f.requestOptions = append(f.requestOptions, opt)
+	opt, err := frankenphp.WithRequestSplitPath(f.SplitPath)
+	if err != nil {
+		return fmt.Errorf("invalid split_path: %w", err)
 	}
+	f.requestOptions = append(f.requestOptions, opt)
 
 	if f.ResolveRootSymlink == nil {
 		f.ResolveRootSymlink = new(true)

Original file line number	Diff line number	Diff line change
`@@ -117,11 +117,11 @@ func (f *FrankenPHPModule) Provision(ctx caddy.Context) error {`
`117`	`117`	`f.SplitPath = []string{".php"}`
`118`	`118`	`}`
`119`	`119`
`120`		`- if opt, err := frankenphp.WithRequestSplitPath(f.SplitPath); err == nil {`
`121`		`- f.requestOptions = append(f.requestOptions, opt)`
`122`		`- } else {`
`123`		`- f.requestOptions = append(f.requestOptions, opt)`
	`120`	`+ opt, err := frankenphp.WithRequestSplitPath(f.SplitPath)`
	`121`	`+ if err != nil {`
	`122`	`+ return fmt.Errorf("invalid split_path: %w", err)`
`124`	`123`	`}`
	`124`	`+ f.requestOptions = append(f.requestOptions, opt)`
`125`	`125`
`126`	`126`	`if f.ResolveRootSymlink == nil {`
`127`	`127`	`f.ResolveRootSymlink = new(true)`