ci: improve security by using GHA environments#2335
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves CI security by moving sensitive workflow jobs onto GitHub Actions Environments, enabling environment-scoped secrets/variables and (optionally) environment protection rules for deployment/publishing paths.
Changes:
- Assigns a
translateenvironment to the docs translation workflow job. - Assigns a
websiteenvironment to the docs deployment workflow job. - Assigns a
dockerhubenvironment to Docker image build/push jobs and switches DockerHub auth tovars.DOCKERHUB_USERNAME+secrets.DOCKERHUB_TOKEN.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/translate.yaml | Runs translation job in the translate environment. |
| .github/workflows/static.yaml | Runs Docker publish-related jobs in the dockerhub environment and updates DockerHub credentials sources. |
| .github/workflows/docs.yaml | Runs website deployment trigger in the website environment. |
| .github/workflows/docker.yaml | Runs Docker build/push jobs in the dockerhub environment and updates DockerHub credentials sources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
henderkes
approved these changes
Apr 8, 2026
Contributor
henderkes
left a comment
henderkes
left a comment
There was a problem hiding this comment.
I can't actually see how the environments are defined, but CI is green, so good in my book.
Member
Author
|
They are defined in GitHub settings. |
Contributor
I know, no permissions to read. But I think even if I did they'd be hidden. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.