Add --no-upx and --no-compress flags#2409
Closed
andreybolonin wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Andrey Bolonin <andreybolonin@users.noreply.github.com>
Signed-off-by: Andrey Bolonin <andreybolonin@users.noreply.github.com>
Contributor
|
This script will likely be deleted entirely somewhat soon (switch to static-php v3). For now, the NO_COMPRESS env variable has to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, developers can skip the UPX compression stage by setting the
NO_COMPRESS=1environment variable. However, this is not immediately obvious, and many users intuitively try to pass flags like--no-upxto the script. Sincebuild-static.shdoesn't parse this argument, the flag is ignored, resulting in a 40-60 minute build time on ARM64/Apple Silicon.This PR adds basic command-line argument parsing to
build-static.sh. Passing--no-upx(or--no-compress) will automatically setNO_COMPRESS=1, making the developer experience much smoother and more intuitive.Related Issue
Closes #2408