Skip to content

test(hotreload): drop caddytest's 5s Client.Timeout #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 2 commits into from
May 16, 2026
+5 −0
Merged

test(hotreload): drop caddytest's 5s Client.Timeout #2431

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac346e0
test(hotreload): drop caddytest's 5s Client.Timeout
dunglas May 16, 2026
7ac9ae0
test(hotreload): use 30s timeout instead of disabling it
dunglas May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions caddy/hotreload_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"strings"
"sync"
"testing"
"time"

"github.com/caddyserver/caddy/v2/caddytest"
"github.com/stretchr/testify/require"
Expand All @@ -25,6 +26,10 @@ func TestHotReload(t *testing.T) {
indexFile := filepath.Join(tmpDir, "index.php")

tester := caddytest.NewTester(t)
// caddytest's default 5s http.Client.Timeout is too tight for the
// SSE roundtrip below on slow CI runners (notably emulated armv7).
// 30s keeps the test bounded so a real regression fails fast.
tester.Client.Timeout = 30 * time.Second
tester.InitServer(`
{
debug
Expand Down
Loading