fix(extgen): correct C param cast in class method wrapper calls#2436
Open
alexandre-daubois wants to merge 1 commit into
Open
fix(extgen): correct C param cast in class method wrapper calls#2436alexandre-daubois wants to merge 1 commit into
alexandre-daubois wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes class method wrapper generation so C arguments are cast based on each parameter type rather than the method return type.
Changes:
- Adds a reusable template helper for class method wrapper call arguments.
- Updates generated method wrapper calls to use the helper.
- Adds tests covering scalar parameter casts across return types.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
internal/extgen/templates/extension.c.tpl |
Refactors class method wrapper argument rendering through methodCallArg. |
internal/extgen/cfile_phpmethod_test.go |
Adds coverage for class method parameter casting behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexandre-daubois
force-pushed
the
extgen-type-fix
branch
from
a966c3f to
fe57608
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As spotted in https://medium.com/@paul.arlott/building-frankenscriptling-running-scriptling-inside-frankenphp-6d4ac95432d2