openssl: Fix missing error propagation in openssl_x509_export()

ndossche · ndossche · commit 02fcd9936ace · 2026-03-07T15:25:19.000+01:00
The file writes can have failed, but this error isn't visible for the application,
fix it by propagating the error properly.
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -1872,8 +1872,7 @@ PHP_FUNCTION(openssl_x509_export)
 	}
 	if (!notext && !X509_print(bio_out, cert)) {
 		php_openssl_store_errors();
-	}
-	if (PEM_write_bio_X509(bio_out, cert)) {
+	} else if (PEM_write_bio_X509(bio_out, cert)) {
 		BUF_MEM *bio_buf;
 
 		BIO_get_mem_ptr(bio_out, &bio_buf);

Original file line number	Diff line number	Diff line change
`@@ -1872,8 +1872,7 @@ PHP_FUNCTION(openssl_x509_export)`
`1872`	`1872`	`}`
`1873`	`1873`	`if (!notext && !X509_print(bio_out, cert)) {`
`1874`	`1874`	`php_openssl_store_errors();`
`1875`		`- }`
`1876`		`- if (PEM_write_bio_X509(bio_out, cert)) {`
	`1875`	`+ } else if (PEM_write_bio_X509(bio_out, cert)) {`
`1877`	`1876`	`BUF_MEM *bio_buf;`
`1878`	`1877`
`1879`	`1878`	`BIO_get_mem_ptr(bio_out, &bio_buf);`