Core: fix missing deprecation when accessing null array key with JIT

Author: alexandre-daubois

Zend/Optimizer/sccp.c

@@ -1535,6 +1535,12 @@ static void sccp_visit_instr(scdf_ctx *scdf, zend_op *opline, zend_ssa_op *ssa_o
 			SKIP_IF_TOP(op1);
 			SKIP_IF_TOP(op2);
 
+			if (op2 && Z_TYPE_P(op2) == IS_NULL) {
+				/* Emits deprecation at run-time. */
+				SET_RESULT_BOT(result);
+				break;
+			}
+
 			if (ct_eval_fetch_dim(&zv, op1, op2, (opline->opcode != ZEND_FETCH_LIST_R)) == SUCCESS) {
 				SET_RESULT(result, &zv);
 				zval_ptr_dtor_nogc(&zv);
@@ -1546,6 +1552,12 @@ static void sccp_visit_instr(scdf_ctx *scdf, zend_op *opline, zend_ssa_op *ssa_o
 			SKIP_IF_TOP(op1);
 			SKIP_IF_TOP(op2);
 
+			if (op2 && Z_TYPE_P(op2) == IS_NULL) {
+				/* Emits deprecation at run-time. */
+				SET_RESULT_BOT(result);
+				break;
+			}
+
 			if (ct_eval_isset_dim(&zv, opline->extended_value, op1, op2) == SUCCESS) {
 				SET_RESULT(result, &zv);
 				zval_ptr_dtor_nogc(&zv);

ext/opcache/tests/jit/fetch_dim_r_001.phpt

@@ -30,14 +30,16 @@ function foo() {
 }
 foo();
 ?>
---EXPECT--
+--EXPECTF--
 int(1)
 int(3)
 int(2)
 int(1)
 int(3)
 int(1)
 int(2)
+
+Deprecated: Using null as an array offset is deprecated, use an empty string instead in %s on line %d
 int(4)
 int(5)
 int(5)