ext/session: use RETURN_BOOL() when possible

Girgias · Girgias · commit 164997518da9 · 2026-02-04T17:46:30.000Z
diff --git a/ext/session/session.c b/ext/session/session.c
@@ -2438,11 +2438,8 @@ PHP_FUNCTION(session_regenerate_id)
 	if (PS(use_cookies)) {
 		PS(send_cookie) = true;
 	}
-	if (php_session_reset_id() == FAILURE) {
-		RETURN_FALSE;
-	}
 
-	RETURN_TRUE;
+	RETURN_BOOL(php_session_reset_id() == SUCCESS);
 }
 
 /* Generate new session ID. Intended for user save handlers. */
@@ -2591,10 +2588,7 @@ PHP_FUNCTION(session_decode)
 		RETURN_FALSE;
 	}
 
-	if (php_session_decode(str) == FAILURE) {
-		RETURN_FALSE;
-	}
-	RETURN_TRUE;
+	RETURN_BOOL(php_session_decode(str) == SUCCESS);
 }
 
 static zend_result php_session_start_set_ini(zend_string *varname, zend_string *new_value) {

Original file line number	Diff line number	Diff line change
`@@ -2438,11 +2438,8 @@ PHP_FUNCTION(session_regenerate_id)`
`2438`	`2438`	`if (PS(use_cookies)) {`
`2439`	`2439`	`PS(send_cookie) = true;`
`2440`	`2440`	`}`
`2441`		`- if (php_session_reset_id() == FAILURE) {`
`2442`		`- RETURN_FALSE;`
`2443`		`- }`
`2444`	`2441`
`2445`		`- RETURN_TRUE;`
	`2442`	`+ RETURN_BOOL(php_session_reset_id() == SUCCESS);`
`2446`	`2443`	`}`
`2447`	`2444`
`2448`	`2445`	`/* Generate new session ID. Intended for user save handlers. */`
`@@ -2591,10 +2588,7 @@ PHP_FUNCTION(session_decode)`
`2591`	`2588`	`RETURN_FALSE;`
`2592`	`2589`	`}`
`2593`	`2590`
`2594`		`- if (php_session_decode(str) == FAILURE) {`
`2595`		`- RETURN_FALSE;`
`2596`		`- }`
`2597`		`- RETURN_TRUE;`
	`2591`	`+ RETURN_BOOL(php_session_decode(str) == SUCCESS);`
`2598`	`2592`	`}`
`2599`	`2593`
`2600`	`2594`	`static zend_result php_session_start_set_ini(zend_string varname, zend_string new_value) {`