Code style

Author: arnaud-lb

Zend/zend_enum.c

@@ -42,7 +42,7 @@ static zend_arg_info zarginfo_class_BackedEnum_tryFrom[sizeof(arginfo_class_Back
 
 zend_object *zend_enum_new(zval *result, zend_class_entry *ce, int case_id, zend_string *case_name, zval *backing_value_zv)
 {
-	zend_enum_obj *intern = zend_object_alloc(sizeof(zend_enum_obj), ce);
+	zend_enum_obj *intern = zend_object_alloc(sizeof(*intern), ce);
 
 	zend_object_std_init(&intern->std, ce);
 	object_properties_init(&intern->std, ce);

Zend/zend_enum.h

@@ -30,7 +30,7 @@ extern ZEND_API zend_class_entry *zend_ce_unit_enum;
 extern ZEND_API zend_class_entry *zend_ce_backed_enum;
 extern ZEND_API zend_object_handlers zend_enum_object_handlers;
 
-typedef struct _zend_enum_obj {
+typedef struct zend_enum_obj {
 	int         case_id;
 	zend_object std;
 } zend_enum_obj;

ext/pcntl/pcntl.c

@@ -1825,27 +1825,20 @@ PHP_FUNCTION(pcntl_getcpu)
 #if defined(HAVE_PTHREAD_SET_QOS_CLASS_SELF_NP)
 static qos_class_t qos_enum_to_pthread(zend_enum_Pcntl_QosClass entry)
 {
-	qos_class_t qos_class;
-
 	switch (entry) {
 	case ZEND_ENUM_Pcntl_QosClass_UserInteractive:
-		qos_class = QOS_CLASS_USER_INTERACTIVE;
-		break;
+		return QOS_CLASS_USER_INTERACTIVE;
 	case ZEND_ENUM_Pcntl_QosClass_UserInitiated:
-		qos_class = QOS_CLASS_USER_INITIATED;
-		break;
+		return QOS_CLASS_USER_INITIATED;
 	case ZEND_ENUM_Pcntl_QosClass_Utility:
-		qos_class = QOS_CLASS_UTILITY;
-		break;
+		return QOS_CLASS_UTILITY;
 	case ZEND_ENUM_Pcntl_QosClass_Background:
-		qos_class = QOS_CLASS_BACKGROUND;
-		break;
+		return QOS_CLASS_BACKGROUND;
 	case ZEND_ENUM_Pcntl_QosClass_Default:
-		qos_class = QOS_CLASS_DEFAULT;
-		break;
+		return QOS_CLASS_DEFAULT;
 	}
 
-	return qos_class;
+	ZEND_UNREACHABLE();
 }
 
 static zend_object *qos_lval_to_zval(qos_class_t qos_class)