Fix arg name

arnaud-lb · arnaud-lb · commit 1f7054a3be34 · 2026-01-21T11:40:49.000+01:00
diff --git a/Zend/tests/partial_application/references_004.phpt b/Zend/tests/partial_application/references_004.phpt
@@ -28,11 +28,11 @@ Closure [ <user> static function {closure:%s:%d} ] {
 
   - Bound Variables [2] {
       Variable #0 [ $a ]
-      Variable #1 [ $args0 ]
+      Variable #1 [ $args1 ]
   }
 
   - Parameters [2] {
-    Parameter #0 [ <required> &$args1 ]
+    Parameter #0 [ <required> &$args0 ]
     Parameter #1 [ <optional> &...$args ]
   }
 }
diff --git a/Zend/zend_partial.c b/Zend/zend_partial.c
@@ -169,7 +169,7 @@ static void zp_assign_names(zend_string **names, uint32_t num_names,
 		}
 		zend_string *orig_name = zp_get_param_name(function, function->common.num_args);
 		zend_string *new_name;
-		for (uint32_t n = offset - function->common.num_args;; n++) {
+		for (uint32_t n = 0;; n++) {
 			new_name = zend_strpprintf_unchecked(0, "%S%" PRIu32, orig_name, n);
 			if (!zp_name_exists(names, num_names, new_name)) {
 				break;

Original file line number	Diff line number	Diff line change
`@@ -28,11 +28,11 @@ Closure [ <user> static function {closure:%s:%d} ] {`
`28`	`28`
`29`	`29`	`- Bound Variables [2] {`
`30`	`30`	`Variable #0 [ $a ]`
`31`		`- Variable #1 [ $args0 ]`
	`31`	`+ Variable #1 [ $args1 ]`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`- Parameters [2] {`
`35`		`- Parameter #0 [ <required> &$args1 ]`
	`35`	`+ Parameter #0 [ <required> &$args0 ]`
`36`	`36`	`Parameter #1 [ <optional> &...$args ]`
`37`	`37`	`}`
`38`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ static void zp_assign_names(zend_string **names, uint32_t num_names,`
`169`	`169`	`}`
`170`	`170`	`zend_string *orig_name = zp_get_param_name(function, function->common.num_args);`
`171`	`171`	`zend_string *new_name;`
`172`		`- for (uint32_t n = offset - function->common.num_args;; n++) {`
	`172`	`+ for (uint32_t n = 0;; n++) {`
`173`	`173`	`new_name = zend_strpprintf_unchecked(0, "%S%" PRIu32, orig_name, n);`
`174`	`174`	`if (!zp_name_exists(names, num_names, new_name)) {`
`175`	`175`	`break;`