openssl: Propagate PHP_OPENSSL_ASN1_INTEGER_set() failure

ndossche · ndossche · commit 369b7b2b740c · 2026-03-07T11:38:53.000+01:00
If this is not propagated, then the function will succeed even though
the serial number is not set.
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -3378,7 +3378,11 @@ PHP_FUNCTION(openssl_csr_sign)
 			goto cleanup;
 		}
 	} else {
-		PHP_OPENSSL_ASN1_INTEGER_set(X509_get_serialNumber(new_cert), serial);
+		if (!PHP_OPENSSL_ASN1_INTEGER_set(X509_get_serialNumber(new_cert), serial)) {
+			php_openssl_store_errors();
+			php_error_docref(NULL, E_WARNING, "Error setting serial number");
+			goto cleanup;
+		}
 	}
 
 	X509_set_subject_name(new_cert, X509_REQ_get_subject_name(csr));

Original file line number	Diff line number	Diff line change
`@@ -3378,7 +3378,11 @@ PHP_FUNCTION(openssl_csr_sign)`
`3378`	`3378`	`goto cleanup;`
`3379`	`3379`	`}`
`3380`	`3380`	`} else {`
`3381`		`- PHP_OPENSSL_ASN1_INTEGER_set(X509_get_serialNumber(new_cert), serial);`
	`3381`	`+ if (!PHP_OPENSSL_ASN1_INTEGER_set(X509_get_serialNumber(new_cert), serial)) {`
	`3382`	`+ php_openssl_store_errors();`
	`3383`	`+ php_error_docref(NULL, E_WARNING, "Error setting serial number");`
	`3384`	`+ goto cleanup;`
	`3385`	`+ }`
`3382`	`3386`	`}`
`3383`	`3387`
`3384`	`3388`	`X509_set_subject_name(new_cert, X509_REQ_get_subject_name(csr));`