review

Author: devnexen

Zend/zend.c

@@ -1502,7 +1502,6 @@ ZEND_API ZEND_COLD void zend_error_zstr_at(
 		info->message = zend_string_copy(message);
 		EG(errors->size)++;
 		if (EG(errors->size) >= EG(errors->capacity)) {
-			// not sure we can get high number of errors so safe `might be` over cautious here
 			uint32_t capacity = EG(errors->capacity) + (EG(errors->capacity) >> 1);
 			EG(errors) = safe_perealloc(EG(errors), sizeof(zend_error_info *), capacity, XtOffsetOf(struct zend_err_buf, buf), true);
 			EG(errors->capacity) = capacity;

Zend/zend_globals.h

@@ -305,6 +305,7 @@ struct _zend_executor_globals {
 	 * and their processing is delayed until zend_emit_recorded_errors()
 	 * is called or a fatal diagnostic is emitted. */
 	bool record_errors;
+	struct zend_err_buf *errors;
 
 	/* Override filename or line number of thrown errors and exceptions */
 	zend_string *filename_override;
@@ -327,7 +328,6 @@ struct _zend_executor_globals {
 	HashTable callable_convert_cache;
 
 	void *reserved[ZEND_MAX_RESERVED_RESOURCES];
-	struct zend_err_buf *errors;
 };
 
 #define EG_FLAGS_INITIAL				(0)