Review

Author: arnaud-lb

Zend/Optimizer/dfa_pass.c

@@ -479,7 +479,7 @@ static uint32_t zend_dfa_optimize_calls(zend_op_array *op_array, zend_ssa *ssa)
 					if (send_opline->op1_type == IS_CONST) {
 						zval *value = CT_CONSTANT_EX(op_array, send_opline->op1.constant);
 						if (Z_TYPE_P(value) == IS_CONSTANT_AST) {
-							/* Const exprs can evaluate to non-cont zvals (e.g. objects), and are not idempotent */
+							/* Const exprs can evaluate to non-const zvals (e.g. objects), and are not idempotent */
 							continue;
 						}
 						const_args |= (1 << i);

Zend/tests/partial_application/const_arg_opt.phpt

@@ -51,7 +51,7 @@ $f(2);
 echo "# Constant pre-bound argument (inverted):\n";
 $f = f(?, 2);
 print_lexical_vars($f);
-$f(2);
+$f(1);
 
 echo "# Inlined pre-bound argument:\n";
 $f = f(g(), ?);
@@ -106,7 +106,7 @@ array(2) {
 no lexical vars
 array(2) {
   [0]=>
-  int(2)
+  int(1)
   [1]=>
   int(2)
 }