add clang-cl to windows nightly CI

Author: henderkes

.github/matrix.php

@@ -148,6 +148,7 @@ function select_jobs($repository, $trigger, $nightly, $labels, $php_version, $re
             ? ['include' => [
                 ['asan' => true, 'opcache' => true, 'x64' => true, 'zts' => true],
                 ['asan' => false, 'opcache' => false, 'x64' => false, 'zts' => false],
+                ['asan' => false, 'opcache' => true, 'x64' => true, 'zts' => true, 'clang' => true],
             ]]
             : ['include' => [['asan' => false, 'opcache' => true, 'x64' => true, 'zts' => true]]];
         $jobs['WINDOWS']['config'] = version_compare($php_version, '8.4', '>=')

.github/scripts/windows/build_task.bat

@@ -30,10 +30,14 @@ if %errorlevel% neq 0 exit /b 3
 
 if "%THREAD_SAFE%" equ "0" set ADD_CONF=%ADD_CONF% --disable-zts
 if "%INTRINSICS%" neq "" set ADD_CONF=%ADD_CONF% --enable-native-intrinsics=%INTRINSICS%
+if "%CLANG_TOOLSET%" equ "1" set ADD_CONF=%ADD_CONF% --with-toolset=clang
 
 rem Some undefined behavior is reported on 32-bit, this should be fixed
 if "%PLATFORM%" == "x86" (
 	set CFLAGS=/W1
+) else if "%CLANG_TOOLSET%" equ "1" (
+	rem Clang is much stricter than MSVC, produces too many warnings that would fail the build with /WX
+	set CFLAGS=/W1
 ) else (
 	set CFLAGS=/W1 /WX
 )

.github/workflows/test-suite.yml

@@ -935,7 +935,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix: ${{ fromJson(inputs.branch).jobs.WINDOWS.matrix }}
-    name: "WINDOWS_${{ matrix.x64 && 'X64' || 'X86' }}_${{ matrix.zts && 'ZTS' || 'NTS' }}${{ matrix.asan && '_ASAN' || ''}}"
+    name: "WINDOWS_${{ matrix.x64 && 'X64' || 'X86' }}_${{ matrix.zts && 'ZTS' || 'NTS' }}${{ matrix.asan && '_ASAN' || ''}}${{ matrix.clang && '_CLANG' || ''}}"
     runs-on: windows-2022
     env:
       PHP_BUILD_CACHE_BASE_DIR: C:\build-cache
@@ -949,6 +949,7 @@ jobs:
       PARALLEL: -j2
       OPCACHE: "${{ matrix.opcache && '1' || '0' }}"
       ASAN: "${{ matrix.asan && '1' || '0' }}"
+      CLANG_TOOLSET: "${{ matrix.clang && '1' || '0' }}"
     steps:
       - name: git config
         run: git config --global core.autocrlf false && git config --global core.eol lf